Add back individual language server controls to status bar menu#45882
Merged
danilo-leal merged 2 commits intomainfrom Jan 2, 2026
Merged
Add back individual language server controls to status bar menu#45882danilo-leal merged 2 commits intomainfrom
danilo-leal merged 2 commits intomainfrom
Conversation
Contributor
|
Superb! If I've understood the code correctly, any error message (e.g. spoiled The only note I have is stylistic: at some point we might want to split that |
Contributor
|
Have been using this and it's great, one functional caveat I see: |
danilo-leal
added a commit
that referenced
this pull request
Jan 4, 2026
This PR makes hitting `enter`/`return` in a submenu trigger also open and focus the submenu instead of closing the parent menu. Building on feedback from @SomeoneToIgnore: #45882 (comment). Release Notes: - N/A
rtfeldman
pushed a commit
that referenced
this pull request
Jan 5, 2026
rtfeldman
pushed a commit
that referenced
this pull request
Jan 5, 2026
This PR makes hitting `enter`/`return` in a submenu trigger also open and focus the submenu instead of closing the parent menu. Building on feedback from @SomeoneToIgnore: #45882 (comment). Release Notes: - N/A
Contributor
|
Doesn't seem to work very well when the error message is too long 2026-01-08.141241.mp4 |
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Jan 20, 2026
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Jan 20, 2026
…ries#46032) This PR makes hitting `enter`/`return` in a submenu trigger also open and focus the submenu instead of closing the parent menu. Building on feedback from @SomeoneToIgnore: zed-industries#45882 (comment). Release Notes: - N/A
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Jan 20, 2026
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Jan 20, 2026
…ries#46032) This PR makes hitting `enter`/`return` in a submenu trigger also open and focus the submenu instead of closing the parent menu. Building on feedback from @SomeoneToIgnore: zed-industries#45882 (comment). Release Notes: - N/A
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we first introduced this menu to the status bar, we had it with individual controls per language server but ended up taking them out mainly because the keyboard navigation story wasn't great. Now that we have submenus, I think we can bring them back with a better UX, both for pointer and keyboard.
Screenshot.2025-12-30.at.6.42.mp4
cc @SomeoneToIgnore for any thoughts and review! I brought most of the code we had (around 6 months ago!) back and adapted what was needed for this to work now.
Release Notes: