Skip to content

project_panel: Fix right-click targeting for folded directory paths#45876

Merged
smitbarmase merged 5 commits intozed-industries:mainfrom
andre-eriksson:fix/gui-create-file-grandparent
Jan 6, 2026
Merged

project_panel: Fix right-click targeting for folded directory paths#45876
smitbarmase merged 5 commits intozed-industries:mainfrom
andre-eriksson:fix/gui-create-file-grandparent

Conversation

@andre-eriksson
Copy link
Contributor

Closes #45635

Release Notes:

  • Fixed context menu in project panel targeting the wrong folder when right-clicking on folded directory paths.
  • Added hover feedback to folded path folders to indicate which folder will be targeted.

Recording:

2025-12-30.18-21-57.mp4

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 30, 2025
Copy link
Member

@smitbarmase smitbarmase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is a great addition.

I made a few tweaks though:

  1. Moved the global set active index method into the FoldedAncestors struct. Felt better to keep it scoped there.
  2. Removed the test for active index tracking on collapse/expand. I don’t think this PR is the right place for that, and honestly I don’t think we should be testing that behavior at all.

@smitbarmase smitbarmase merged commit 2c7bfec into zed-industries:main Jan 6, 2026
23 checks passed
rtfeldman pushed a commit that referenced this pull request Jan 6, 2026
Closes #45635

Release Notes:

- Fixed context menu in project panel targeting the wrong folder when
right-clicking on folded directory paths.
- Added hover feedback to folded path folders to indicate which folder
will be targeted.

Recording:


https://github.com/user-attachments/assets/3209921a-b791-4eef-8eb7-1b5dc68374da

---------

Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
LivioGama pushed a commit to LivioGama/zed that referenced this pull request Jan 20, 2026
…ustries#45876)

Closes zed-industries#45635

Release Notes:

- Fixed context menu in project panel targeting the wrong folder when
right-clicking on folded directory paths.
- Added hover feedback to folded path folders to indicate which folder
will be targeted.

Recording:


https://github.com/user-attachments/assets/3209921a-b791-4eef-8eb7-1b5dc68374da

---------

Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
LivioGama pushed a commit to LivioGama/zed that referenced this pull request Jan 20, 2026
…ustries#45876)

Closes zed-industries#45635

Release Notes:

- Fixed context menu in project panel targeting the wrong folder when
right-clicking on folded directory paths.
- Added hover feedback to folded path folders to indicate which folder
will be targeted.

Recording:


https://github.com/user-attachments/assets/3209921a-b791-4eef-8eb7-1b5dc68374da

---------

Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
LivioGama pushed a commit to LivioGama/zed that referenced this pull request Feb 15, 2026
…ustries#45876)

Closes zed-industries#45635

Release Notes:

- Fixed context menu in project panel targeting the wrong folder when
right-clicking on folded directory paths.
- Added hover feedback to folded path folders to indicate which folder
will be targeted.

Recording:


https://github.com/user-attachments/assets/3209921a-b791-4eef-8eb7-1b5dc68374da

---------

Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GUI: Cannot create a file in grandparent folder with right-click when path is single-lined

2 participants