project_panel: Fix right-click targeting for folded directory paths#45876
Merged
smitbarmase merged 5 commits intozed-industries:mainfrom Jan 6, 2026
Merged
Conversation
Added a helper function to ensure both use the same logic
smitbarmase
approved these changes
Jan 6, 2026
Member
smitbarmase
left a comment
There was a problem hiding this comment.
Thanks! This is a great addition.
I made a few tweaks though:
- Moved the global set active index method into the
FoldedAncestorsstruct. Felt better to keep it scoped there. - Removed the test for active index tracking on collapse/expand. I don’t think this PR is the right place for that, and honestly I don’t think we should be testing that behavior at all.
rtfeldman
pushed a commit
that referenced
this pull request
Jan 6, 2026
Closes #45635 Release Notes: - Fixed context menu in project panel targeting the wrong folder when right-clicking on folded directory paths. - Added hover feedback to folded path folders to indicate which folder will be targeted. Recording: https://github.com/user-attachments/assets/3209921a-b791-4eef-8eb7-1b5dc68374da --------- Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Jan 20, 2026
…ustries#45876) Closes zed-industries#45635 Release Notes: - Fixed context menu in project panel targeting the wrong folder when right-clicking on folded directory paths. - Added hover feedback to folded path folders to indicate which folder will be targeted. Recording: https://github.com/user-attachments/assets/3209921a-b791-4eef-8eb7-1b5dc68374da --------- Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Jan 20, 2026
…ustries#45876) Closes zed-industries#45635 Release Notes: - Fixed context menu in project panel targeting the wrong folder when right-clicking on folded directory paths. - Added hover feedback to folded path folders to indicate which folder will be targeted. Recording: https://github.com/user-attachments/assets/3209921a-b791-4eef-8eb7-1b5dc68374da --------- Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Feb 15, 2026
…ustries#45876) Closes zed-industries#45635 Release Notes: - Fixed context menu in project panel targeting the wrong folder when right-clicking on folded directory paths. - Added hover feedback to folded path folders to indicate which folder will be targeted. Recording: https://github.com/user-attachments/assets/3209921a-b791-4eef-8eb7-1b5dc68374da --------- Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #45635
Release Notes:
Recording:
2025-12-30.18-21-57.mp4