vim: Fix word object count multiplier (2aw, 2iw)#45686
Merged
ConradIrwin merged 4 commits intozed-industries:mainfrom Jan 5, 2026
Merged
vim: Fix word object count multiplier (2aw, 2iw)#45686ConradIrwin merged 4 commits intozed-industries:mainfrom
ConradIrwin merged 4 commits intozed-industries:mainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
51fba6b to
e021c61
Compare
Previously, commands like `d2aw` or `2daw` would only delete a single word, ignoring the numeric multiplier. This was because the `times` parameter was passed through the system but the word text object functions (`in_word`, `around_word`) ignored it. This change adds `times` parameter support to: - `in_word()`: Extends selection to include N words - `around_word()`: Propagates times to helper functions - `around_containing_word()`: Passes times to in_word() - `around_next_word()`: Counts words and stops at Nth word - `Object::range()`: Passes times.unwrap_or(1) to word functions
e021c61 to
6452283
Compare
fcc18f6 to
554d76e
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
|
We might need to handle cases where multiple operations include line breaks. |
Contributor
Author
|
@Kalmaegi good catch |
Member
|
Thank you, and thanks for the tests! |
Contributor
Author
|
thanks @ConradIrwin! |
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Jan 20, 2026
Closes zed-industries#44251 ## Context Commands like `2daw` or `c2iw` were ignoring the count multiplier because the word text object functions (`in_word`, `around_word`) weren't using the `times` parameter. This fix propagates the count through these functions so all operators correctly handle multiple words. ## Before https://github.com/user-attachments/assets/d5effa8a-4c04-4d70-a6b5-389cba730ca9 ## After https://github.com/user-attachments/assets/c50e4c0c-ea5c-4673-9c98-3d924b448025 Release Notes: - Fixed vim mode count multiplier for word text objects (`2aw`, `2iw`, `2aW`, `2iW`)
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Jan 20, 2026
Closes zed-industries#44251 ## Context Commands like `2daw` or `c2iw` were ignoring the count multiplier because the word text object functions (`in_word`, `around_word`) weren't using the `times` parameter. This fix propagates the count through these functions so all operators correctly handle multiple words. ## Before https://github.com/user-attachments/assets/d5effa8a-4c04-4d70-a6b5-389cba730ca9 ## After https://github.com/user-attachments/assets/c50e4c0c-ea5c-4673-9c98-3d924b448025 Release Notes: - Fixed vim mode count multiplier for word text objects (`2aw`, `2iw`, `2aW`, `2iW`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44251
Context
Commands like
2daworc2iwwere ignoring the count multiplier because the word text object functions (in_word,around_word) weren't using thetimesparameter. This fix propagates the count through these functions so all operators correctly handle multiple words.Before
Screen.Recording.2025-12-26.at.12.22.44.PM.mov
After
Screen.Recording.2025-12-26.at.12.23.43.PM.mov
Release Notes:
2aw,2iw,2aW,2iW)