agent_ui: Fix issues with mention crease#45683
Merged
danilo-leal merged 3 commits intomainfrom Dec 29, 2025
Merged
Conversation
CherryWorm
pushed a commit
to CherryWorm/zed
that referenced
this pull request
Dec 30, 2025
This PR introduces the `MentionCrease` component, aimed at solving two issues with mention creases in the agent panel: - Previously, the mention crease was using a button with a regular size, which is bigger than the default buffer font line height. That made the crease look clipped and also overlapping with one another when in a multiple line scenario where the creases would be on top of each other. `MentionCrease` uses the window line height value to set the button height, with a small one pixel vertical padding just for a bit of spacing. - Previously, given the crease used a `Label`, its font size wouldn't scale if you changed the `agent_buffer_font_size` setting. Now, `MentionCrease` uses that font size value, which makes regular text and its text grow together as you'd expect. Release Notes: - agent: Fix a bug where mention creases didn't scale with `agent_buffer_font_size` and got clipped/jumbled when rendered one above the other.
rtfeldman
pushed a commit
that referenced
this pull request
Jan 5, 2026
This PR introduces the `MentionCrease` component, aimed at solving two issues with mention creases in the agent panel: - Previously, the mention crease was using a button with a regular size, which is bigger than the default buffer font line height. That made the crease look clipped and also overlapping with one another when in a multiple line scenario where the creases would be on top of each other. `MentionCrease` uses the window line height value to set the button height, with a small one pixel vertical padding just for a bit of spacing. - Previously, given the crease used a `Label`, its font size wouldn't scale if you changed the `agent_buffer_font_size` setting. Now, `MentionCrease` uses that font size value, which makes regular text and its text grow together as you'd expect. Release Notes: - agent: Fix a bug where mention creases didn't scale with `agent_buffer_font_size` and got clipped/jumbled when rendered one above the other.
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Jan 20, 2026
This PR introduces the `MentionCrease` component, aimed at solving two issues with mention creases in the agent panel: - Previously, the mention crease was using a button with a regular size, which is bigger than the default buffer font line height. That made the crease look clipped and also overlapping with one another when in a multiple line scenario where the creases would be on top of each other. `MentionCrease` uses the window line height value to set the button height, with a small one pixel vertical padding just for a bit of spacing. - Previously, given the crease used a `Label`, its font size wouldn't scale if you changed the `agent_buffer_font_size` setting. Now, `MentionCrease` uses that font size value, which makes regular text and its text grow together as you'd expect. Release Notes: - agent: Fix a bug where mention creases didn't scale with `agent_buffer_font_size` and got clipped/jumbled when rendered one above the other.
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Jan 20, 2026
This PR introduces the `MentionCrease` component, aimed at solving two issues with mention creases in the agent panel: - Previously, the mention crease was using a button with a regular size, which is bigger than the default buffer font line height. That made the crease look clipped and also overlapping with one another when in a multiple line scenario where the creases would be on top of each other. `MentionCrease` uses the window line height value to set the button height, with a small one pixel vertical padding just for a bit of spacing. - Previously, given the crease used a `Label`, its font size wouldn't scale if you changed the `agent_buffer_font_size` setting. Now, `MentionCrease` uses that font size value, which makes regular text and its text grow together as you'd expect. Release Notes: - agent: Fix a bug where mention creases didn't scale with `agent_buffer_font_size` and got clipped/jumbled when rendered one above the other.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the
MentionCreasecomponent, aimed at solving two issues with mention creases in the agent panel:MentionCreaseuses the window line height value to set the button height, with a small one pixel vertical padding just for a bit of spacing.Label, its font size wouldn't scale if you changed theagent_buffer_font_sizesetting. Now,MentionCreaseuses that font size value, which makes regular text and its text grow together as you'd expect.Release Notes:
agent_buffer_font_sizeand got clipped/jumbled when rendered one above the other.