Skip to content

agent_ui: Fix issues with mention crease#45683

Merged
danilo-leal merged 3 commits intomainfrom
mention-crease-component
Dec 29, 2025
Merged

agent_ui: Fix issues with mention crease#45683
danilo-leal merged 3 commits intomainfrom
mention-crease-component

Conversation

@danilo-leal
Copy link
Member

@danilo-leal danilo-leal commented Dec 26, 2025

This PR introduces the MentionCrease component, aimed at solving two issues with mention creases in the agent panel:

  • Previously, the mention crease was using a button with a regular size, which is bigger than the default buffer font line height. That made the crease look clipped and also overlapping with one another when in a multiple line scenario where the creases would be on top of each other. MentionCrease uses the window line height value to set the button height, with a small one pixel vertical padding just for a bit of spacing.
  • Previously, given the crease used a Label, its font size wouldn't scale if you changed the agent_buffer_font_size setting. Now, MentionCrease uses that font size value, which makes regular text and its text grow together as you'd expect.

Release Notes:

  • agent: Fix a bug where mention creases didn't scale with agent_buffer_font_size and got clipped/jumbled when rendered one above the other.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 26, 2025
@danilo-leal danilo-leal merged commit 9e88f3f into main Dec 29, 2025
25 checks passed
@danilo-leal danilo-leal deleted the mention-crease-component branch December 29, 2025 11:27
CherryWorm pushed a commit to CherryWorm/zed that referenced this pull request Dec 30, 2025
This PR introduces the `MentionCrease` component, aimed at solving two
issues with mention creases in the agent panel:
- Previously, the mention crease was using a button with a regular size,
which is bigger than the default buffer font line height. That made the
crease look clipped and also overlapping with one another when in a
multiple line scenario where the creases would be on top of each other.
`MentionCrease` uses the window line height value to set the button
height, with a small one pixel vertical padding just for a bit of
spacing.
- Previously, given the crease used a `Label`, its font size wouldn't
scale if you changed the `agent_buffer_font_size` setting. Now,
`MentionCrease` uses that font size value, which makes regular text and
its text grow together as you'd expect.

Release Notes:

- agent: Fix a bug where mention creases didn't scale with
`agent_buffer_font_size` and got clipped/jumbled when rendered one above
the other.
rtfeldman pushed a commit that referenced this pull request Jan 5, 2026
This PR introduces the `MentionCrease` component, aimed at solving two
issues with mention creases in the agent panel:
- Previously, the mention crease was using a button with a regular size,
which is bigger than the default buffer font line height. That made the
crease look clipped and also overlapping with one another when in a
multiple line scenario where the creases would be on top of each other.
`MentionCrease` uses the window line height value to set the button
height, with a small one pixel vertical padding just for a bit of
spacing.
- Previously, given the crease used a `Label`, its font size wouldn't
scale if you changed the `agent_buffer_font_size` setting. Now,
`MentionCrease` uses that font size value, which makes regular text and
its text grow together as you'd expect.

Release Notes:

- agent: Fix a bug where mention creases didn't scale with
`agent_buffer_font_size` and got clipped/jumbled when rendered one above
the other.
LivioGama pushed a commit to LivioGama/zed that referenced this pull request Jan 20, 2026
This PR introduces the `MentionCrease` component, aimed at solving two
issues with mention creases in the agent panel:
- Previously, the mention crease was using a button with a regular size,
which is bigger than the default buffer font line height. That made the
crease look clipped and also overlapping with one another when in a
multiple line scenario where the creases would be on top of each other.
`MentionCrease` uses the window line height value to set the button
height, with a small one pixel vertical padding just for a bit of
spacing.
- Previously, given the crease used a `Label`, its font size wouldn't
scale if you changed the `agent_buffer_font_size` setting. Now,
`MentionCrease` uses that font size value, which makes regular text and
its text grow together as you'd expect.

Release Notes:

- agent: Fix a bug where mention creases didn't scale with
`agent_buffer_font_size` and got clipped/jumbled when rendered one above
the other.
LivioGama pushed a commit to LivioGama/zed that referenced this pull request Jan 20, 2026
This PR introduces the `MentionCrease` component, aimed at solving two
issues with mention creases in the agent panel:
- Previously, the mention crease was using a button with a regular size,
which is bigger than the default buffer font line height. That made the
crease look clipped and also overlapping with one another when in a
multiple line scenario where the creases would be on top of each other.
`MentionCrease` uses the window line height value to set the button
height, with a small one pixel vertical padding just for a bit of
spacing.
- Previously, given the crease used a `Label`, its font size wouldn't
scale if you changed the `agent_buffer_font_size` setting. Now,
`MentionCrease` uses that font size value, which makes regular text and
its text grow together as you'd expect.

Release Notes:

- agent: Fix a bug where mention creases didn't scale with
`agent_buffer_font_size` and got clipped/jumbled when rendered one above
the other.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant