Skip to content

Remove implicit dependency on Node env for data_dir devcontainer CLI#45589

Merged
KyleBarton merged 2 commits intomainfrom
fix_devcontainer_node_dependency
Jan 6, 2026
Merged

Remove implicit dependency on Node env for data_dir devcontainer CLI#45589
KyleBarton merged 2 commits intomainfrom
fix_devcontainer_node_dependency

Conversation

@KyleBarton
Copy link
Collaborator

Closes #45058

Release Notes:

  • Fixed implicit dependency on a system node for running devcontainers.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 23, 2025
@KyleBarton KyleBarton enabled auto-merge (squash) December 23, 2025 19:32
@KyleBarton KyleBarton disabled auto-merge December 23, 2025 19:34
@maxdeviant maxdeviant changed the title Remove implicit dependency on node env for data_dir devcontainer cli Remove implicit dependency on Node env for data_dir devcontainer CLI Dec 24, 2025
@KyleBarton KyleBarton enabled auto-merge (squash) January 6, 2026 17:57
@KyleBarton KyleBarton merged commit f057d46 into main Jan 6, 2026
23 checks passed
@KyleBarton KyleBarton deleted the fix_devcontainer_node_dependency branch January 6, 2026 18:00
LivioGama pushed a commit to LivioGama/zed that referenced this pull request Jan 20, 2026
…ed-industries#45589)

Closes zed-industries#45058

Release Notes:

- Fixed implicit dependency on a system `node` for running
devcontainers.
LivioGama pushed a commit to LivioGama/zed that referenced this pull request Jan 20, 2026
…ed-industries#45589)

Closes zed-industries#45058

Release Notes:

- Fixed implicit dependency on a system `node` for running
devcontainers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Starting devcontainer project doesn't work without node but it's "hard" to figure out why

1 participant