terminal: Prevent terminal cursor stretching by always using cell width#45545
Merged
Veykril merged 7 commits intozed-industries:mainfrom Feb 2, 2026
Merged
terminal: Prevent terminal cursor stretching by always using cell width#45545Veykril merged 7 commits intozed-industries:mainfrom
Veykril merged 7 commits intozed-industries:mainfrom
Conversation
537afcb to
d1fed3c
Compare
Veykril
requested changes
Jan 5, 2026
Member
Veykril
left a comment
There was a problem hiding this comment.
I don't think this is quite right, that will look funny for emojis and other non-standard cell characters. Let's do a check if the text fragment consists solely of whitespace instead, and if that is the case fall back to the cell width instead
# Conflicts: # crates/terminal_view/src/terminal_element.rs
64b2447 to
2de00f7
Compare
Veykril
reviewed
Jan 26, 2026
Member
Veykril
left a comment
There was a problem hiding this comment.
As assumed this still breaks the cursor for bigger non whitespace glyphs
Contributor
Author
It should work this time |
Member
|
needs a cargo fmt |
auto-merge was automatically disabled
January 30, 2026 11:07
Head branch was pushed to by a user without write access
adb-sh
pushed a commit
to adb-sh/zed
that referenced
this pull request
Feb 5, 2026
…th (zed-industries#45545) Closes zed-industries#8516 Release Notes: - Prevent terminal cursor stretching by always using cell width.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8516
Release Notes: