Skip to content

agent_ui: Expand model favoriting feature to external agents#45528

Merged
danilo-leal merged 14 commits intomainfrom
favorite-models-upgrade
Dec 22, 2025
Merged

agent_ui: Expand model favoriting feature to external agents#45528
danilo-leal merged 14 commits intomainfrom
favorite-models-upgrade

Conversation

@danilo-leal
Copy link
Member

This PR adds the ability to favorite models for external agents—writing to the settings in the agent_servers key—as well as a handful of other improvements:

  • Make the cycling keybinding alt-enter work for the inline assistant as well as previous user messages
  • Better organized the keybinding files removing some outdated agent-related keybinding definitions
  • Renamed the inline assistant key context to "InlineAssistant" as "PromptEditor" is old and confusing
  • Made the keybindings to rate an inline assistant response visible in the thumbs up/down button's tooltip
  • Created a unified component for the model selector tooltip given we had 3 different places creating the same element
  • Make the "Cycle Favorited Models" row in the tooltip visible only if there is more than one favorite models

Release Notes:

  • agent: External agents also now support the favoriting model feature, which comes with a handy keybinding to cycle through the favorite list.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 22, 2025
@danilo-leal danilo-leal merged commit f9d9721 into main Dec 22, 2025
23 checks passed
@danilo-leal danilo-leal deleted the favorite-models-upgrade branch December 22, 2025 17:06
rtfeldman pushed a commit that referenced this pull request Jan 5, 2026
This PR adds the ability to favorite models for external agents—writing
to the settings in the `agent_servers` key—as well as a handful of other
improvements:

- Make the cycling keybinding `alt-enter` work for the inline assistant
as well as previous user messages
- Better organized the keybinding files removing some outdated
agent-related keybinding definitions
- Renamed the inline assistant key context to "InlineAssistant" as
"PromptEditor" is old and confusing
- Made the keybindings to rate an inline assistant response visible in
the thumbs up/down button's tooltip
- Created a unified component for the model selector tooltip given we
had 3 different places creating the same element
- Make the "Cycle Favorited Models" row in the tooltip visible only if
there is more than one favorite models

Release Notes:

- agent: External agents also now support the favoriting model feature,
which comes with a handy keybinding to cycle through the favorite list.
LivioGama pushed a commit to LivioGama/zed that referenced this pull request Jan 20, 2026
…ustries#45528)

This PR adds the ability to favorite models for external agents—writing
to the settings in the `agent_servers` key—as well as a handful of other
improvements:

- Make the cycling keybinding `alt-enter` work for the inline assistant
as well as previous user messages
- Better organized the keybinding files removing some outdated
agent-related keybinding definitions
- Renamed the inline assistant key context to "InlineAssistant" as
"PromptEditor" is old and confusing
- Made the keybindings to rate an inline assistant response visible in
the thumbs up/down button's tooltip
- Created a unified component for the model selector tooltip given we
had 3 different places creating the same element
- Make the "Cycle Favorited Models" row in the tooltip visible only if
there is more than one favorite models

Release Notes:

- agent: External agents also now support the favoriting model feature,
which comes with a handy keybinding to cycle through the favorite list.
LivioGama pushed a commit to LivioGama/zed that referenced this pull request Jan 20, 2026
…ustries#45528)

This PR adds the ability to favorite models for external agents—writing
to the settings in the `agent_servers` key—as well as a handful of other
improvements:

- Make the cycling keybinding `alt-enter` work for the inline assistant
as well as previous user messages
- Better organized the keybinding files removing some outdated
agent-related keybinding definitions
- Renamed the inline assistant key context to "InlineAssistant" as
"PromptEditor" is old and confusing
- Made the keybindings to rate an inline assistant response visible in
the thumbs up/down button's tooltip
- Created a unified component for the model selector tooltip given we
had 3 different places creating the same element
- Make the "Cycle Favorited Models" row in the tooltip visible only if
there is more than one favorite models

Release Notes:

- agent: External agents also now support the favoriting model feature,
which comes with a handy keybinding to cycle through the favorite list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant