gpui: Fix hover state getting stuck when rapidly hovering over elements#45437
Merged
MrSubidubi merged 3 commits intozed-industries:mainfrom Dec 21, 2025
Merged
gpui: Fix hover state getting stuck when rapidly hovering over elements#45437MrSubidubi merged 3 commits intozed-industries:mainfrom
MrSubidubi merged 3 commits intozed-industries:mainfrom
Conversation
Contributor
Author
screen-recording-gpui-hover-state.movHere is the example I useduse gpui::{
AppContext, Application, Bounds, Context, InteractiveElement, IntoElement, ParentElement,
Render, Styled, Window, WindowBounds, WindowOptions, div, px, rgb, size,
};
struct App {}
impl Render for App {
fn render(&mut self, _window: &mut Window, _cx: &mut Context<Self>) -> impl IntoElement {
let background = rgb(0x1a1a1a);
let item_bg_hover = rgb(0x292929);
let text_default = rgb(0xd6d6dc);
let text_hover = rgb(0xf0ab75);
let border = rgb(0x4d4d4d);
div()
.flex()
.flex_col()
.size_full()
.text_color(text_default)
.bg(rgb(0x111111))
.text_xs()
.p_3()
.child(div().mb_2().text_lg().text_center().child("Lists"))
.child(
div()
.flex()
.bg(background)
.border_1()
.border_color(border)
.rounded_md()
.py_2()
.children((0..10).map(|col| {
div().flex_1().children((1..=30).map(|idx| {
div()
.id(format!("item-{}-{}", col, idx))
.w_full()
.rounded_sm()
.flex()
.items_center()
.justify_center()
.hover(|style| {
style.bg(item_bg_hover).text_color(text_hover).underline()
})
.child(format!("Item {}.{:02}", col + 1, idx))
}))
})),
)
}
}
fn main() {
Application::new().run(|cx| {
let bounds = Bounds::centered(None, size(px(900.), px(700.)), cx);
cx.open_window(
WindowOptions {
window_bounds: Some(WindowBounds::Windowed(bounds)),
..Default::default()
},
|_window, cx| cx.new(|_cx| App {}),
)
.unwrap();
});
} |
|
I can confirm that the issue is fixed. |
MrSubidubi
reviewed
Dec 20, 2025
Member
|
Should be good to go after #45461 |
MrSubidubi
approved these changes
Dec 21, 2025
danilo-leal
added a commit
that referenced
this pull request
Jan 8, 2026
Tackling this as I noticed a bug in the agent panel where the button to delete a thread, which appeared only on hover, stopped showing up. PRs #43324 and #45437 fixed stuff in applying hover styles through `.hover()` but broke the `.on_hover()` callback. Problem was that both methods were sharing the same `element_state.hover_state` but running at different phases. The solution here was to add a new independent state field for the hover listener (`hover_listener_state`) while the hover style method keeps using `hover_state`. Release Notes: - Agent: Fixed a bug where the button to delete a thread stopped showing up.
github-actions bot
pushed a commit
that referenced
this pull request
Jan 14, 2026
Tackling this as I noticed a bug in the agent panel where the button to delete a thread, which appeared only on hover, stopped showing up. PRs #43324 and #45437 fixed stuff in applying hover styles through `.hover()` but broke the `.on_hover()` callback. Problem was that both methods were sharing the same `element_state.hover_state` but running at different phases. The solution here was to add a new independent state field for the hover listener (`hover_listener_state`) while the hover style method keeps using `hover_state`. Release Notes: - Agent: Fixed a bug where the button to delete a thread stopped showing up.
zed-zippy bot
added a commit
that referenced
this pull request
Jan 14, 2026
#46831) Cherry-pick of #46371 to stable ---- Tackling this as I noticed a bug in the agent panel where the button to delete a thread, which appeared only on hover, stopped showing up. PRs #43324 and #45437 fixed stuff in applying hover styles through `.hover()` but broke the `.on_hover()` callback. Problem was that both methods were sharing the same `element_state.hover_state` but running at different phases. The solution here was to add a new independent state field for the hover listener (`hover_listener_state`) while the hover style method keeps using `hover_state`. Release Notes: - Agent: Fixed a bug where the button to delete a thread stopped showing up. Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Jan 20, 2026
…ts (zed-industries#45437) Closes zed-industries#45436 Release Notes: - N/A --------- Co-authored-by: MrSubidubi <finn@zed.dev>
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Jan 20, 2026
…ts (zed-industries#45437) Closes zed-industries#45436 Release Notes: - N/A --------- Co-authored-by: MrSubidubi <finn@zed.dev>
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Feb 15, 2026
…ts (zed-industries#45437) Closes zed-industries#45436 Release Notes: - N/A --------- Co-authored-by: MrSubidubi <finn@zed.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #45436
Release Notes: