Fix terminal doesn't switch to project directory when opening remote project on Windows#45328
Conversation
crates/remote/src/transport/ssh.rs
Outdated
|
|
||
| // The command needs to be executed in a new shell, so it requires quoting again | ||
| let exec_after_quote = ssh_shell_kind | ||
| .try_quote(&exec) | ||
| .context("shell quoting")? | ||
| .into(); |
There was a problem hiding this comment.
This doesn't seem right, the shell builder should already be taking care of this See my comment below
|
After reading through the linked issue. I thought we rolled back the ssh changes from https://github.com/zed-industries/zed/pull/42382/changes#diff-b99ed7bdf450d3faca488eec030a9bb40e0ed83598b50aa12a6bc1c7e2c41c6e but I guess we did not. I think we just want to undo that part from that PR. Iirc we did not intend to do that. |
4fb5e5a to
4a05f7b
Compare
|
@Veykril Already undo the ssh part from that PR. |
|
Probably you know now that this is not specific to Windows. I'm on Mac and had the same issue SSH'd into a local Docker container. This fixes it. Thanks! |
|
/cherry-pick preview |
|
🍒💥 Cherry-pick did not succeed |
…project on Windows (zed-industries#45328) Closes zed-industries#45253 Release Notes: - Fixed terminal doesn't switch to project directory when opening remote project on Windows
…project on Windows (zed-industries#45328) Closes zed-industries#45253 Release Notes: - Fixed terminal doesn't switch to project directory when opening remote project on Windows
…project on Windows (zed-industries#45328) Closes zed-industries#45253 Release Notes: - Fixed terminal doesn't switch to project directory when opening remote project on Windows
Closes #45253
Release Notes: