Skip to content

Don't trigger autosave on focus change in modals#45166

Merged
probably-neb merged 1 commit intomainfrom
dont-trigger-autosave-on-focus-loss-in-modals
Dec 17, 2025
Merged

Don't trigger autosave on focus change in modals#45166
probably-neb merged 1 commit intomainfrom
dont-trigger-autosave-on-focus-loss-in-modals

Conversation

@probably-neb
Copy link
Collaborator

Closes #28732

Release Notes:

  • Opening the command palette or other modals no longer triggers auto-save with the { "autosave": "on_focus_change" } setting. This reduces the chance of unwanted format changes when executing actions, and fixes a race condition with :w in Vim mode

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 17, 2025
@probably-neb probably-neb merged commit 25e1e2e into main Dec 17, 2025
24 checks passed
@probably-neb probably-neb deleted the dont-trigger-autosave-on-focus-loss-in-modals branch December 17, 2025 22:42
rtfeldman pushed a commit that referenced this pull request Jan 5, 2026
Closes #28732

Release Notes:

- Opening the command palette or other modals no longer triggers
auto-save with the `{ "autosave": "on_focus_change" }` setting. This
reduces the chance of unwanted format changes when executing actions,
and fixes a race condition with `:w` in Vim mode
LivioGama pushed a commit to LivioGama/zed that referenced this pull request Jan 20, 2026
Closes zed-industries#28732

Release Notes:

- Opening the command palette or other modals no longer triggers
auto-save with the `{ "autosave": "on_focus_change" }` setting. This
reduces the chance of unwanted format changes when executing actions,
and fixes a race condition with `:w` in Vim mode
LivioGama pushed a commit to LivioGama/zed that referenced this pull request Jan 20, 2026
Closes zed-industries#28732

Release Notes:

- Opening the command palette or other modals no longer triggers
auto-save with the `{ "autosave": "on_focus_change" }` setting. This
reduces the chance of unwanted format changes when executing actions,
and fixes a race condition with `:w` in Vim mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vim Mode :w interferes with format-on-save & autosave on focus loss

1 participant