Skip to content

Revert "gpui: Take advantage of unified memory on Apple silicon (#44273)"#45022

Merged
JosephTLyons merged 1 commit intomainfrom
Revert-gpui-Take-advantage-of-unified-memory-on-Apple-silicon-(#44273)-
Dec 16, 2025
Merged

Revert "gpui: Take advantage of unified memory on Apple silicon (#44273)"#45022
JosephTLyons merged 1 commit intomainfrom
Revert-gpui-Take-advantage-of-unified-memory-on-Apple-silicon-(#44273)-

Conversation

@JosephTLyons
Copy link
Collaborator

@JosephTLyons JosephTLyons commented Dec 16, 2025

Closes: #45020

This reverts commit 2441dc3.

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 16, 2025
@JosephTLyons JosephTLyons enabled auto-merge (squash) December 16, 2025 19:30
@rtfeldman
Copy link
Contributor

We can un-revert this once gfx-rs/metal-rs#374 lands and gets published. At that point we should be able to bump our dependency, un-revert, and verify that it works on Intel Macs.

@cwfitzgerald
Copy link

wgpu release is tomorrow, so I'll publish metal too tomorrow.

@JosephTLyons JosephTLyons merged commit abcf5a1 into main Dec 16, 2025
24 checks passed
@JosephTLyons JosephTLyons deleted the Revert-gpui-Take-advantage-of-unified-memory-on-Apple-silicon-(#44273)- branch December 16, 2025 19:42
@rtfeldman
Copy link
Contributor

Awesome, thank you @cwfitzgerald! 🙌

@JosephTLyons
Copy link
Collaborator Author

@marcocondrache, just wanting to keep you in the loop

@marcocondrache
Copy link
Contributor

@JosephTLyons thank you! I really appreciate it

JosephTLyons added a commit that referenced this pull request Dec 16, 2025
@JosephTLyons
Copy link
Collaborator Author

No problem!

HactarCE pushed a commit that referenced this pull request Dec 17, 2025
@filipwiech
Copy link

filipwiech commented Dec 18, 2025

@marcocondrache metal-rs 0.33 with a fix from @rtfeldman is now released. 👍 Would be great to see this re-land. 🙂

aviatesk added a commit to aviatesk/zed that referenced this pull request Jan 10, 2026
LivioGama pushed a commit to LivioGama/zed that referenced this pull request Jan 20, 2026
LivioGama pushed a commit to LivioGama/zed that referenced this pull request Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Zed Nightly (2025-12-16) broken on Mac Intel

5 participants