Skip to content

acp_thread: Decode file:// mention paths so non-ASCII names render correctly#44983

Merged
Veykril merged 1 commit intozed-industries:mainfrom
daiconic:fix/encoded-filename
Dec 16, 2025
Merged

acp_thread: Decode file:// mention paths so non-ASCII names render correctly#44983
Veykril merged 1 commit intozed-industries:mainfrom
daiconic:fix/encoded-filename

Conversation

@daiconic
Copy link
Contributor

@daiconic daiconic commented Dec 16, 2025 •
edited
Loading

Summary

This fixes a minor bug I found #44981

  • Fix percent-encoded filenames appearing in agent mentions after message submission.
  • Decode file:// paths in MentionUri::parse using the existing urlencoding crate (already used elsewhere in the codebase).
  • Add tests for non-ASCII file URIs.

Screenshots

image

Release Notes

  • Fixed percent-encoded filenames appearing in agent message file mentions.

@cla-bot
Copy link

cla-bot bot commented Dec 16, 2025

We require contributors to sign our Contributor License Agreement, and we don't have @Suzushiro-radish on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@Veykril Veykril self-assigned this Dec 16, 2025
@Veykril Veykril changed the title fix: decode file:// mention paths so non-ASCII names render correctly in acp_thread acp_thread: decode file:// mention paths so non-ASCII names render correctly in acp_thread Dec 16, 2025
Veykril
Veykril approved these changes Dec 16, 2025
View reviewed changes
Copy link
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Veykril
Copy link
Member

Veykril commented Dec 16, 2025

You'll need to sign the CLA

chatgpt-codex-connector[bot]
chatgpt-codex-connector bot reviewed Dec 16, 2025
View reviewed changes
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@daiconic
Copy link
Contributor Author

daiconic commented Dec 16, 2025

@cla-bot check

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 16, 2025
@cla-bot
Copy link

cla-bot bot commented Dec 16, 2025

The cla-bot has been summoned, and re-checked this pull request!

@daiconic
Copy link
Contributor Author

daiconic commented Dec 16, 2025

@Veykril
Thank you for the approval!
I've signed the CLA.
Really appreciate all the work on Zed.

@Veykril Veykril enabled auto-merge (squash) December 16, 2025 12:56
@zed-industries-bot
Copy link
Contributor

zed-industries-bot commented Dec 16, 2025 •
edited
Loading

Warnings
⚠️

This PR is missing release notes.

Please add a "Release Notes" section that describes the change:

Release Notes:

- Added/Fixed/Improved ...

If your change is not user-facing, you can use "N/A" for the entry:

Release Notes:

- N/A

Generated by 🚫 dangerJS against 298c7ec

auto-merge was automatically disabled December 16, 2025 13:00

Head branch was pushed to by a user without write access

@daiconic daiconic force-pushed the fix/encoded-filename branch from f8c665c to 298c7ec Compare December 16, 2025 13:01
@daiconic daiconic changed the title acp_thread: decode file:// mention paths so non-ASCII names render correctly in acp_thread acp_thread: Decode file:// mention paths so non-ASCII names render correctly Dec 16, 2025
@Veykril Veykril enabled auto-merge (squash) December 16, 2025 13:06
@daiconic
Copy link
Contributor Author

daiconic commented Dec 16, 2025

It looks like the Windows CI is failing on vim object::test::test_minibrackets_object (https://github.com/zed-industries/zed/actions/runs/20268821356/job/58199398266).

This seems unrelated to the acp_thread URI decoding change in this PR.
I don't have permission to re-run CI from my side—could someone please re-run the Windows job / workflow?

@Veykril Veykril merged commit 0362e30 into zed-industries:main Dec 16, 2025
37 of 39 checks passed
@daiconic daiconic mentioned this pull request Dec 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@Veykril Veykril Veykril approved these changes

Assignees

@Veykril Veykril

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@daiconic @Veykril @zed-industries-bot