project: Sanitize single-line completions from trailing newlines#44965
project: Sanitize single-line completions from trailing newlines#44965MrSubidubi merged 4 commits intozed-industries:mainfrom
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @prayanshchh on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
@cla-bot check |
|
We require contributors to sign our Contributor License Agreement, and we don't have @prayanshchh on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@cla-bot check |
|
We require contributors to sign our Contributor License Agreement, and we don't have @prayanshchh on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
please review if there is any change in approach required, will fix failing tests |
MrSubidubi
left a comment
There was a problem hiding this comment.
Nice, looks good, thank you!
And congratulations to your first contribution! 🎉
|
thank u so much!! |
) Closes #43991 trim documentation string to prevent completion overlap previous [Screencast from 2025-12-16 14-55-58.webm](https://github.com/user-attachments/assets/d7674d82-63b0-4a85-a90f-b5c5091e4a82) after change [Screencast from 2025-12-16 14-50-05.webm](https://github.com/user-attachments/assets/109c22b5-3fff-49c8-a2ec-b1af467d6320) Release Notes: - Fixed an issue where completions in the completion menu would span multiple lines.
…-industries#44965) Closes zed-industries#43991 trim documentation string to prevent completion overlap previous [Screencast from 2025-12-16 14-55-58.webm](https://github.com/user-attachments/assets/d7674d82-63b0-4a85-a90f-b5c5091e4a82) after change [Screencast from 2025-12-16 14-50-05.webm](https://github.com/user-attachments/assets/109c22b5-3fff-49c8-a2ec-b1af467d6320) Release Notes: - Fixed an issue where completions in the completion menu would span multiple lines.
…-industries#44965) Closes zed-industries#43991 trim documentation string to prevent completion overlap previous [Screencast from 2025-12-16 14-55-58.webm](https://github.com/user-attachments/assets/d7674d82-63b0-4a85-a90f-b5c5091e4a82) after change [Screencast from 2025-12-16 14-50-05.webm](https://github.com/user-attachments/assets/109c22b5-3fff-49c8-a2ec-b1af467d6320) Release Notes: - Fixed an issue where completions in the completion menu would span multiple lines.
…-industries#44965) Closes zed-industries#43991 trim documentation string to prevent completion overlap previous [Screencast from 2025-12-16 14-55-58.webm](https://github.com/user-attachments/assets/d7674d82-63b0-4a85-a90f-b5c5091e4a82) after change [Screencast from 2025-12-16 14-50-05.webm](https://github.com/user-attachments/assets/109c22b5-3fff-49c8-a2ec-b1af467d6320) Release Notes: - Fixed an issue where completions in the completion menu would span multiple lines.
Closes #43991
trim documentation string to prevent completion overlap
previous
Screencast from 2025-12-16 14-55-58.webm
after change
Screencast from 2025-12-16 14-50-05.webm
Release Notes: