lsp: Support on-type formatting request with newlines#44882
Merged
Conversation
We called out to `request_on_type_formatting` only in handle_input function, but newlines are actually handled by editor::Newline action.
Member
Author
|
@janko I'm sorry you had to wait so long for something that was admittedly pretty simple in hindsight. |
Contributor
|
Great, thanks! 🙌🏻 I sensed it's just a matter of calling the LSP request, but I understand it's not always easy to tell whether a problem has a simple solution 😄 |
CherryWorm
pushed a commit
to CherryWorm/zed
that referenced
this pull request
Dec 16, 2025
…#44882) We called out to `request_on_type_formatting` only in handle_input function, but newlines are actually handled by editor::Newline action. Closes zed-industries#12383 Release Notes: - Added support for on-type formatting with newlines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We called out to
request_on_type_formattingonly in handle_input function, but newlines are actually handled by editor::Newline action.Closes #12383
Release Notes: