I'm having issues with the test editor_tests::test_toggle_comment. I'm struggling with whitespace handling, and the assertion keeps failing. It's driving me crazy, and I think I need the team's support on this one

The test now fails because it seems we have differing behavior here.

    cx.assert_editor_state(indoc! {"
        fn a() {
            // «b();
-            // c();
-            ˇ»//  d();
+            ˇ»// «c();
+            ˇ» // d();
        }
    "});

Note how we now end up with two selections after invoking ToggleComments where as before we only had one. Which makes sense, looking at the editor state before that assertion, we have two selections touching each other which now no longer merge. And the whitespace change also comes from that, because we remain with two selections here and thus consider different columns for each

@Veykril Thanks so much for this - that helped it click for me. I was counting the markers as columns, but they disappear in the final marked text. Rookie mistake 😄

@marcocondrache, I'll make an issue for this later, but figured I'd bring it up here first. I'm assuming a separate issue, but once you start typing, things gets merged.

@JosephTLyons wow, thank you for discovering this. Could you assign the issue to me? I will provide a fix immediately

@JosephTLyons wow, thank you for discovering this. Could you assign the issue to me? I will provide a fix immediately

Thank you so much! Here's the issue. I'm weirdly not able to assign it currently, I think we might have some permission issues going on since we migrated over to an GH organization. Maybe if you comment on the issue, I can assign.

• Adjacent selection merge upon insertion of text #45046