Redact environment variables from language server spawn errors#44783
Merged
SomeoneToIgnore merged 1 commit intozed-industries:mainfrom Dec 18, 2025
Merged
Redact environment variables from language server spawn errors#44783SomeoneToIgnore merged 1 commit intozed-industries:mainfrom
SomeoneToIgnore merged 1 commit intozed-industries:mainfrom
Conversation
Contributor
Author
|
Error observed: 
Test with: "lsp": {
"clangd": {
"binary": {
"path": "",
},
},
},CC: @SomeoneToIgnore |
SomeoneToIgnore
approved these changes
Dec 18, 2025
Contributor
SomeoneToIgnore
left a comment
There was a problem hiding this comment.
Sorry for the delay, it was a rough week (or two?).
I feel that overall, we need to do something better than matching arbitrary strings with regexes, but that's a start and since we do that on errors only, let's try and see how things work.
Contributor
Author
|
Thanks for merging. Yeah, I was definitely happy when the main redact implementation was not regex based and this is definitely a hack. P.S. Congrats on shipping trust ed workspaces. |
rtfeldman
pushed a commit
that referenced
this pull request
Jan 5, 2026
Redact environment variables from zed logs when lsp fails to spawn. Release Notes: - N/A
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Jan 20, 2026
…ndustries#44783) Redact environment variables from zed logs when lsp fails to spawn. Release Notes: - N/A
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Jan 20, 2026
…ndustries#44783) Redact environment variables from zed logs when lsp fails to spawn. Release Notes: - N/A
Anthony-Eid
pushed a commit
that referenced
this pull request
Feb 25, 2026
tahayvr
pushed a commit
to tahayvr/zed
that referenced
this pull request
Mar 4, 2026
Closes zed-industries#50007 - Follow-up to: zed-industries#44783 Release Notes: - Improved redaction of sensitive environment variables from debugger error logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redact environment variables from zed logs when lsp fails to spawn.
Release Notes: