Skip to content

Fixed hotkey not functioning in the JetBrains keymap on macOS#44756

Closed
18o wants to merge 2 commits intozed-industries:mainfrom
18o:jetbrains_keymap
Closed

Fixed hotkey not functioning in the JetBrains keymap on macOS#44756
18o wants to merge 2 commits intozed-industries:mainfrom
18o:jetbrains_keymap

Conversation

@18o
Copy link

@18o 18o commented Dec 13, 2025 •
edited
Loading

Closes #44752
Closes #44330

Copilot AI review requested due to automatic review settings December 13, 2025 01:46
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 13, 2025
@zed-industries-bot
Copy link
Contributor

zed-industries-bot commented Dec 13, 2025 •
edited
Loading

Warnings
⚠️

This PR is missing release notes.

Please add a "Release Notes" section that describes the change:

Release Notes:

- Added/Fixed/Improved ...

If your change is not user-facing, you can use "N/A" for the entry:

Release Notes:

- N/A

Generated by 🚫 dangerJS against e2b7cef

@18o 18o changed the title fix: resolve cmd-e not working in JetBrains keymap for macOS Resolve cmd-e not working in JetBrains keymap for macOS Dec 13, 2025
@18o 18o changed the title Resolve cmd-e not working in JetBrains keymap for macOS Fixed cmd-e not working in JetBrains keymap for macOS Dec 13, 2025

This comment was marked as spam.

Sign in to view

@yeskunall yeskunall self-assigned this Dec 13, 2025
yeskunall
yeskunall reviewed Dec 13, 2025
View reviewed changes
Copy link
Member

@yeskunall yeskunall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you tell me if these keybindings look correct? There are 3 references to file_finder::Toggle, but I’m not sure about L109-L110. Are those valid keybindings?

@18o 18o changed the title Fixed cmd-e not working in JetBrains keymap for macOS Fixed hotkey not functioning in the JetBrains keymap on macOS Dec 13, 2025
SomeoneToIgnore
SomeoneToIgnore requested changes Dec 14, 2025
View reviewed changes
assets/keymaps/macos/jetbrains.json
"cmd-e": "file_finder::Toggle",
"alt-enter": "editor::ToggleCodeActions",
"ctrl-space": "editor::ShowCompletions",
"cmd-j": "editor::Hover",
Copy link
Contributor

@SomeoneToIgnore SomeoneToIgnore Dec 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong: #44111

@SomeoneToIgnore SomeoneToIgnore mentioned this pull request Dec 16, 2025
Merged
CherryWorm pushed a commit to CherryWorm/zed that referenced this pull request Dec 16, 2025
@SomeoneToIgnore @CherryWorm
Fix the file_finder::Toggle binding (zed-industries#44951)
da34b6e 
Closes zed-industries#44752
Closes zed-industries#44756

Release Notes:

- Fixed "file_finder::Toggle" action sometimes not working in JetBrains
keymap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yeskunall yeskunall yeskunall left review comments

Copilot code review Copilot Copilot left review comments

@SomeoneToIgnore SomeoneToIgnore SomeoneToIgnore requested changes

Assignees

@SomeoneToIgnore SomeoneToIgnore

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The JetBrains keymap is not functioning properly. JetBrains keybinding (⌘P) not working

5 participants

@18o @zed-industries-bot @SomeoneToIgnore @yeskunall