Fix dock panel button tooltip not dismissed when state changes via keyboard shortcut#44746
Merged
MrSubidubi merged 2 commits intozed-industries:mainfrom Dec 21, 2025
Merged
Conversation
Member
|
Thanks for this! I just pushed a minor update so that we do not allocate a string but use a different type of There is one thing left to discuss for me: Do we want to stick with this approach or go with a different one? Currently, we just hide the tooltip, but an alternative would be that we update the tooltip based on the current panel state so that it continues to exist and the accurate keystroke/action is displayed. What do you think about that? |
Contributor
Author
|
Hi, thanks! When I initially wrote the issue, I thought the tooltip should be updated. However, I wasn't able to implement it due to my limited understanding of the code. Since this behavior is somewhat obscure, I think simply hiding the tooltip would be sufficient. This approach is also consistent with the mouse behavior. |
MrSubidubi
approved these changes
Dec 21, 2025
Member
MrSubidubi
left a comment
There was a problem hiding this comment.
Looks good. I think there is a slight difference between the mouse and keyboard interaction, that's why I was a bit hesistant to merge this this way. Yet, the other way is way more complicated and just dismissing is perhaps not the 100% solution, but 99% for sure 🙂
Thank you for looking into and fixing this!
rtfeldman
pushed a commit
that referenced
this pull request
Jan 5, 2026
…yboard shortcut (#44746) Closes #44720 Release Notes: - Fixed dock panel button tooltips not being dismissed when toggling panels via keyboard shortcut **Problem:** When hovering over a dock panel button and using a keyboard shortcut to toggle the panel, the tooltip remains visible with stale content. This is inconsistent with mouse click behavior, where the tooltip is dismissed on mouse down. **Solution:** Include the panel's active state in the button's element ID. When the state changes, the element ID changes (e.g., `"DebugPanel"` → `"DebugPanel-active"`), which causes GPUI to discard the old element state including the cached tooltip. **Testing:** Manually verified: 1. Hover over a dock panel button, wait for tooltip 2. Press keyboard shortcut to toggle the panel 3. Tooltip is now dismissed (consistent with mouse click behavior) https://github.com/user-attachments/assets/ed92fb6c-6c22-44e2-87e3-5461d35f7106 --------- Co-authored-by: MrSubidubi <finn@zed.dev>
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Jan 20, 2026
…yboard shortcut (zed-industries#44746) Closes zed-industries#44720 Release Notes: - Fixed dock panel button tooltips not being dismissed when toggling panels via keyboard shortcut **Problem:** When hovering over a dock panel button and using a keyboard shortcut to toggle the panel, the tooltip remains visible with stale content. This is inconsistent with mouse click behavior, where the tooltip is dismissed on mouse down. **Solution:** Include the panel's active state in the button's element ID. When the state changes, the element ID changes (e.g., `"DebugPanel"` → `"DebugPanel-active"`), which causes GPUI to discard the old element state including the cached tooltip. **Testing:** Manually verified: 1. Hover over a dock panel button, wait for tooltip 2. Press keyboard shortcut to toggle the panel 3. Tooltip is now dismissed (consistent with mouse click behavior) https://github.com/user-attachments/assets/ed92fb6c-6c22-44e2-87e3-5461d35f7106 --------- Co-authored-by: MrSubidubi <finn@zed.dev>
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Jan 20, 2026
…yboard shortcut (zed-industries#44746) Closes zed-industries#44720 Release Notes: - Fixed dock panel button tooltips not being dismissed when toggling panels via keyboard shortcut **Problem:** When hovering over a dock panel button and using a keyboard shortcut to toggle the panel, the tooltip remains visible with stale content. This is inconsistent with mouse click behavior, where the tooltip is dismissed on mouse down. **Solution:** Include the panel's active state in the button's element ID. When the state changes, the element ID changes (e.g., `"DebugPanel"` → `"DebugPanel-active"`), which causes GPUI to discard the old element state including the cached tooltip. **Testing:** Manually verified: 1. Hover over a dock panel button, wait for tooltip 2. Press keyboard shortcut to toggle the panel 3. Tooltip is now dismissed (consistent with mouse click behavior) https://github.com/user-attachments/assets/ed92fb6c-6c22-44e2-87e3-5461d35f7106 --------- Co-authored-by: MrSubidubi <finn@zed.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44720
Release Notes:
Problem: When hovering over a dock panel button and using a keyboard shortcut to toggle the panel, the tooltip remains visible with stale content. This is inconsistent with mouse click behavior, where the tooltip is dismissed on mouse down.
Solution: Include the panel's active state in the button's element ID. When the state changes, the element ID changes (e.g.,
"DebugPanel"→"DebugPanel-active"), which causes GPUI to discard the old element state including the cached tooltip.Testing: Manually verified:
2025-12-13.02.02.02.mov