Fix micromamba not initializing shell#44646
Conversation
|
I branched from my previous commit, but I am seeing that they are not merged on main yet which is why the history is there. You can ignore it and just focus on the latest commit. |
|
You'll need to rebase this onto main, we use a squash workflow so the history changes after a merge |
bbbb1fa to
03b0a8f
Compare
|
I made a big mess but restored it now I think. Changes are minor. |
|
I will rebase -- one moment please. |
6252305 to
82a8bc0
Compare
82a8bc0 to
5c3c9dd
Compare
|
Sorry for the mess the changes are clean now -- need to get some coffee -_- |
crates/languages/src/python.rs
Outdated
| let env_name = toolchain.environment.name.as_deref().unwrap_or("base"); | ||
| activation_script.push(format!("{manager} activate {env_name}")); | ||
|
|
||
| if let Some(name) = &toolchain.environment.name { | ||
| activation_script.push(format!("{manager} activate {name}")); |
There was a problem hiding this comment.
That change looks unnecessary, we already push that activate invocation here after all
There was a problem hiding this comment.
You are right -- think this is a remnant of the rebase shenaningans. Will fix
Closes zed-industries#44645 This is a continuation of zed-industries#40577 Release Notes: - initializes micromamba based on the shell
|
@Klaim - might want to check this out for micromamba and conda support in Zed |
Closes #44645
This is a continuation of #40577
Release Notes: