Update file vs folder open keymaps on macOS/linux to match Windows#44598
Conversation
assets/keymaps/default-macos.json
Outdated
| "cmd-o": "workspace::Open", | ||
| "cmd-o": "workspace::OpenFiles", | ||
| "cmd-k cmd-o": "workspace::Open", |
There was a problem hiding this comment.
It seems vscode only has cmd-o for open, so this change should not be made here given the default keymap is vscode specific
There was a problem hiding this comment.
Should I remove the cmd-k cmd-o from Windows as well or just the 2 I added?
There was a problem hiding this comment.
No windows is correct. Its just on mac where these differ weirdly enough (and I presume linux uses the same as windows here, so that change should check out)
There was a problem hiding this comment.
OK done. For future would it have been preferable to amend it? I definitely would have on a lot of projects but I like to ask because I don't want to make people review changes twice if they don't want to no matter how small. Like, as a zed culture thing if I make a tiny PR and have to make a change should I amend if it makes sense, or always make a new commit?
There was a problem hiding this comment.
Committing is probably preferred as we do squash merges, so it will ultimately end up as a single commit anyways
Co-authored-by: Lukas Wirth <me@lukaswirth.dev>
|
Thanks! |
|
Thank you! By the way, what would it take to get traige? I'd really enjoy tagging issues. |
…ed-industries#44598) Closes zed-industries#44597 Matches what was done here: zed-industries@55dfbac#diff-cc832e840d61526768bb4acec7645a71e8b160a65a30e7ce9e9c51762b58199a Release Notes: - Standardize Cmd-O = open file, Cmd-K Cmd-O = open folder across operating systems. --------- Co-authored-by: Lukas Wirth <me@lukaswirth.dev>
…ed-industries#44598) Closes zed-industries#44597 Matches what was done here: zed-industries@55dfbac#diff-cc832e840d61526768bb4acec7645a71e8b160a65a30e7ce9e9c51762b58199a Release Notes: - Standardize Cmd-O = open file, Cmd-K Cmd-O = open folder across operating systems. --------- Co-authored-by: Lukas Wirth <me@lukaswirth.dev>
…ed-industries#44598) Closes zed-industries#44597 Matches what was done here: zed-industries@55dfbac#diff-cc832e840d61526768bb4acec7645a71e8b160a65a30e7ce9e9c51762b58199a Release Notes: - Standardize Cmd-O = open file, Cmd-K Cmd-O = open folder across operating systems. --------- Co-authored-by: Lukas Wirth <me@lukaswirth.dev>
Closes #44597
Matches what was done here:
55dfbac#diff-cc832e840d61526768bb4acec7645a71e8b160a65a30e7ce9e9c51762b58199a
Release Notes: