Add scrolling functionality to markdown preview mode#44585
Merged
KyleBarton merged 6 commits intomainfrom Dec 11, 2025
Merged
Conversation
nrbnlulu
pushed a commit
to nrbnlulu/zed
that referenced
this pull request
Dec 14, 2025
…44585) Closes zed-industries#21324 Adds four new commands: - `markdown::MoveUp`, `markdown::MoveDown` - these scroll up and down in markdown preview mode, by no more than the height of a large headline. - `markdown::MoveUpByItem`, and `markdown::MoveDownByItem` - these scroll up and down by the height of the item at the top of the markdown preview window. So headlines and large codeblocks, for instance, scroll further than individual paragraph lines. Also attempts to create sensible defaults: `down` -> `markdown::ScrollDown` `up` -> `markdown::ScrollUp` `alt-down` -> `markdown::ScrollDownByItem` `alt-up` -> `markdown::ScrollUpByItem` And in Vim: `ctrl-u` -> `markdown::ScrollPageUp` `ctrl-d` -> `markdown::ScrollPageDown` `ctrl-e` -> `markdown::ScrollDown` `ctrl-y` -> `markdown::ScrollUp` Release Notes: - Added commands `markdown::ScrollUp`, `markdown::ScrollDown`, `markdown::ScrollUpByItem`, and `markdown::ScrollDownByItem` - Changed commands `markdown::MovePageUp` to `markdown::ScrollPageUp` and `markdown::MovePageDown` to `markdown::ScrollPageDown`
CherryWorm
pushed a commit
to CherryWorm/zed
that referenced
this pull request
Dec 16, 2025
…44585) Closes zed-industries#21324 Adds four new commands: - `markdown::MoveUp`, `markdown::MoveDown` - these scroll up and down in markdown preview mode, by no more than the height of a large headline. - `markdown::MoveUpByItem`, and `markdown::MoveDownByItem` - these scroll up and down by the height of the item at the top of the markdown preview window. So headlines and large codeblocks, for instance, scroll further than individual paragraph lines. Also attempts to create sensible defaults: `down` -> `markdown::ScrollDown` `up` -> `markdown::ScrollUp` `alt-down` -> `markdown::ScrollDownByItem` `alt-up` -> `markdown::ScrollUpByItem` And in Vim: `ctrl-u` -> `markdown::ScrollPageUp` `ctrl-d` -> `markdown::ScrollPageDown` `ctrl-e` -> `markdown::ScrollDown` `ctrl-y` -> `markdown::ScrollUp` Release Notes: - Added commands `markdown::ScrollUp`, `markdown::ScrollDown`, `markdown::ScrollUpByItem`, and `markdown::ScrollDownByItem` - Changed commands `markdown::MovePageUp` to `markdown::ScrollPageUp` and `markdown::MovePageDown` to `markdown::ScrollPageDown`
someone13574
pushed a commit
to someone13574/zed
that referenced
this pull request
Dec 16, 2025
…44585) Closes zed-industries#21324 Adds four new commands: - `markdown::MoveUp`, `markdown::MoveDown` - these scroll up and down in markdown preview mode, by no more than the height of a large headline. - `markdown::MoveUpByItem`, and `markdown::MoveDownByItem` - these scroll up and down by the height of the item at the top of the markdown preview window. So headlines and large codeblocks, for instance, scroll further than individual paragraph lines. Also attempts to create sensible defaults: `down` -> `markdown::ScrollDown` `up` -> `markdown::ScrollUp` `alt-down` -> `markdown::ScrollDownByItem` `alt-up` -> `markdown::ScrollUpByItem` And in Vim: `ctrl-u` -> `markdown::ScrollPageUp` `ctrl-d` -> `markdown::ScrollPageDown` `ctrl-e` -> `markdown::ScrollDown` `ctrl-y` -> `markdown::ScrollUp` Release Notes: - Added commands `markdown::ScrollUp`, `markdown::ScrollDown`, `markdown::ScrollUpByItem`, and `markdown::ScrollDownByItem` - Changed commands `markdown::MovePageUp` to `markdown::ScrollPageUp` and `markdown::MovePageDown` to `markdown::ScrollPageDown`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21324
Adds four new commands:
markdown::MoveUp,markdown::MoveDown- these scroll up and down in markdown preview mode, by no more than the height of a large headline.markdown::MoveUpByItem, andmarkdown::MoveDownByItem- these scroll up and down by the height of the item at the top of the markdown preview window. So headlines and large codeblocks, for instance, scroll further than individual paragraph lines.Also attempts to create sensible defaults:
down->markdown::ScrollDownup->markdown::ScrollUpalt-down->markdown::ScrollDownByItemalt-up->markdown::ScrollUpByItemAnd in Vim:
ctrl-u->markdown::ScrollPageUpctrl-d->markdown::ScrollPageDownctrl-e->markdown::ScrollDownctrl-y->markdown::ScrollUpRelease Notes:
markdown::ScrollUp,markdown::ScrollDown,markdown::ScrollUpByItem, andmarkdown::ScrollDownByItemmarkdown::MovePageUptomarkdown::ScrollPageUpandmarkdown::MovePageDowntomarkdown::ScrollPageDown