Conversation
… leads to buffer having a legit language Fixes a bug that led to us unnecessarily restarting a language server when we were looking at a single file of a given language.
SomeoneToIgnore
approved these changes
Dec 9, 2025
Contributor
SomeoneToIgnore
left a comment
There was a problem hiding this comment.
Thank you for finding this.
The only wish is to have a test to be sure we do not restart the server again in a similar situation.
Yet the problem is that our fake_lsp-related infra won't do that?
Member
Author
|
Yeah, not sure; I've tried the following, with no luck: Gonna switch to Copilot stuff in the meantime. |
CherryWorm
pushed a commit
to CherryWorm/zed
that referenced
this pull request
Dec 16, 2025
… leads to buffer having a legit language (zed-industries#44469) Fixes a bug that led to us unnecessarily restarting a language server when we were looking at a single file of a given language. Release Notes: - Fixed a bug that led to Zed sometimes starting an excessive amount of language servers
someone13574
pushed a commit
to someone13574/zed
that referenced
this pull request
Dec 16, 2025
… leads to buffer having a legit language (zed-industries#44469) Fixes a bug that led to us unnecessarily restarting a language server when we were looking at a single file of a given language. Release Notes: - Fixed a bug that led to Zed sometimes starting an excessive amount of language servers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug that led to us unnecessarily restarting a language server when we were looking at a single file of a given language.
Release Notes: