editor: Fix link navigation within editors that don't have a workspace#44389
Merged
editor: Fix link navigation within editors that don't have a workspace#44389
Conversation
This mostly affects Channel Notes, but due to a change in #43921 we were short-circuiting before opening links. I moved the workspace checks back to right before we need them so that we still follow the same control flow as usual for these editors.
CherryWorm
pushed a commit
to CherryWorm/zed
that referenced
this pull request
Dec 16, 2025
zed-industries#44389) This mostly affects Channel Notes, but due to a change in zed-industries#43921 we were short-circuiting before opening links. I moved the workspace checks back to right before we need them so that we still follow the same control flow as usual for these editors. Closes zed-industries#44207 Release Notes: - N/A
someone13574
pushed a commit
to someone13574/zed
that referenced
this pull request
Dec 16, 2025
zed-industries#44389) This mostly affects Channel Notes, but due to a change in zed-industries#43921 we were short-circuiting before opening links. I moved the workspace checks back to right before we need them so that we still follow the same control flow as usual for these editors. Closes zed-industries#44207 Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mostly affects Channel Notes, but due to a change in #43921 we were short-circuiting before opening links.
I moved the workspace checks back to right before we need them so that we still follow the same control flow as usual for these editors.
Closes #44207
Release Notes: