Skip to content

editor: Use Tree-sitter scopes to calculate quote autoclose#44281

Merged
probably-neb merged 4 commits intozed-industries:mainfrom
errmayank:quote-autoclose
Dec 15, 2025
Merged

editor: Use Tree-sitter scopes to calculate quote autoclose#44281
probably-neb merged 4 commits intozed-industries:mainfrom
errmayank:quote-autoclose

Conversation

@errmayank
Copy link
Contributor

Closes #44233

Release Notes:

  • Fixed quote autoclose incorrectly counting quotes inside strings

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 6, 2025
@github-actions github-actions bot added the community champion Issues filed by our amazing community champions! 🫶 label Dec 6, 2025
@maxdeviant maxdeviant changed the title editor: Use tree-sitter scopes to calculate quote autoclose editor: Use Tree-sitter scopes to calculate quote autoclose Dec 6, 2025
@github-project-automation github-project-automation bot moved this to Community Champion PRs in Quality Week – December 2025 Dec 12, 2025
@probably-neb probably-neb moved this from Community Champion PRs to In progress in Quality Week – December 2025 Dec 15, 2025
@probably-neb
Copy link
Collaborator

While reviewing I noticed you were using char offsets, while the gpui::Point type uses byte offsets. I added a test and a fix for the issue.

I think this PR is a great addition! Thanks!

@probably-neb probably-neb merged commit 523f093 into zed-industries:main Dec 15, 2025
23 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Quality Week – December 2025 Dec 15, 2025
CherryWorm pushed a commit to CherryWorm/zed that referenced this pull request Dec 16, 2025
…stries#44281)

Closes zed-industries#44233

Release Notes:

- Fixed quote autoclose incorrectly counting quotes inside strings

---------

Co-authored-by: Ben Kunkle <ben@zed.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement community champion Issues filed by our amazing community champions! 🫶

Projects

Development

Successfully merging this pull request may close these issues.

[Python] Autocompletion of double quote struggles when double quote in string in the same line

2 participants