Specify a schema to use when dealing with JSONC files#44250
Merged
SomeoneToIgnore merged 2 commits intomainfrom Dec 5, 2025
Merged
Specify a schema to use when dealing with JSONC files#44250SomeoneToIgnore merged 2 commits intomainfrom
SomeoneToIgnore merged 2 commits intomainfrom
Conversation
Also make all JSONC file overrides to use the schema.
CherryWorm
pushed a commit
to CherryWorm/zed
that referenced
this pull request
Dec 16, 2025
…#44250) Follow-up of zed-industries#43854 Closes zed-industries#40970 Seems that json language server does not distinguish between JSONC and JSON files in runtime, but there is a static schema, which accepts globs in its `fileMatch` fields. Use all glob overrides and file suffixes for JSONC inside those match fields, and provide a grammar for such matches, which accepts trailing commas. Release Notes: - Improved JSONC trailing comma handling
someone13574
pushed a commit
to someone13574/zed
that referenced
this pull request
Dec 16, 2025
…#44250) Follow-up of zed-industries#43854 Closes zed-industries#40970 Seems that json language server does not distinguish between JSONC and JSON files in runtime, but there is a static schema, which accepts globs in its `fileMatch` fields. Use all glob overrides and file suffixes for JSONC inside those match fields, and provide a grammar for such matches, which accepts trailing commas. Release Notes: - Improved JSONC trailing comma handling
|
@SomeoneToIgnore |
Contributor
Author
|
Yes, that's what an opinionated Prettier does when formatting jsonc files, so correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #43854
Closes #40970
Seems that json language server does not distinguish between JSONC and JSON files in runtime, but there is a static schema, which accepts globs in its
fileMatchfields.Use all glob overrides and file suffixes for JSONC inside those match fields, and provide a grammar for such matches, which accepts trailing commas.
Release Notes: