Skip to content

Fix project not getting dropped after closing window#44237

Merged
bennetbo merged 3 commits intomainfrom
fix-agent-panel-project-leak
Dec 5, 2025
Merged

Fix project not getting dropped after closing window#44237
bennetbo merged 3 commits intomainfrom
fix-agent-panel-project-leak

Conversation

@bennetbo
Copy link
Member

@bennetbo bennetbo commented Dec 5, 2025 •
edited
Loading

We created cycles by storing strong references to project in:

  • TextThreadStore
  • TextThread
  • acp::MessageEditor

Release Notes:

  • Fixed an issue where memory usage would not go down after closing a window

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 5, 2025
@bennetbo bennetbo marked this pull request as ready for review December 5, 2025 18:16
@bennetbo bennetbo merged commit f9cea5a into main Dec 5, 2025
24 checks passed
@bennetbo bennetbo deleted the fix-agent-panel-project-leak branch December 5, 2025 18:53
@Veykril
Copy link
Member

Veykril commented Dec 5, 2025

/cherry-pick stable
/cherry-pick preview

github-actions bot pushed a commit that referenced this pull request Dec 5, 2025
@bennetbo
Fix project not getting dropped after closing window (#44237)
b00e82d
github-actions bot pushed a commit that referenced this pull request Dec 5, 2025
@bennetbo
Fix project not getting dropped after closing window (#44237)
fb8b3b6
This was referenced Dec 5, 2025
Merged
Merged
zed-zippy bot added a commit that referenced this pull request Dec 5, 2025
@zed-zippy @bennetbo
Fix project not getting dropped after closing window (#44237) (cherry…
fa54c5b 
…-pick to stable) (#44241)

Cherry-pick of #44237 to stable

----

Co-authored-by: Bennet Bo Fenner <bennet@zed.dev>
zed-zippy bot added a commit that referenced this pull request Dec 5, 2025
@zed-zippy @bennetbo
Fix project not getting dropped after closing window (#44237) (cherry…
b1dd884 
…-pick to preview) (#44240)

Cherry-pick of #44237 to preview

----

Co-authored-by: Bennet Bo Fenner <bennet@zed.dev>
@SomeoneToIgnore SomeoneToIgnore mentioned this pull request Dec 6, 2025
Closed
CherryWorm pushed a commit to CherryWorm/zed that referenced this pull request Dec 16, 2025
@bennetbo @CherryWorm
Fix project not getting dropped after closing window (zed-industries#…
747d82e 
…44237)
someone13574 pushed a commit to someone13574/zed that referenced this pull request Dec 16, 2025
@bennetbo @someone13574
Fix project not getting dropped after closing window (zed-industries#…
3f877ae 
…44237)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bennetbo @Veykril