remoting: Server download connect timeout#44216
Merged
Conversation
Contributor
88310ea to
3936157
Compare
agu-z
commented
Dec 5, 2025
Comment on lines
+711
to
+712
| "--tries", | ||
| "1", |
Contributor
Author
There was a problem hiding this comment.
By default, wget retries up to 20 times! Given we don't retry at all with curl (which we always use over wget when available), I think we can disable this here. I'd rather fall back to the client-side download as soon as possible.
Veykril
approved these changes
Dec 5, 2025
CherryWorm
pushed a commit
to CherryWorm/zed
that referenced
this pull request
Dec 16, 2025
Sometimes machines are configured to drop outbound packets (rather than reject connections). In these cases, curl/wget just hang causing our download step to never complete. This PR adds a timeout of 10s for the connection (not the whole download), so that in situations like this we can fallback to our client-side download eventually. Related to but doesn't fully fix: zed-industries#43694 and zed-industries#43718 Release Notes: - remote: Add 10s connect timeout for server download
someone13574
pushed a commit
to someone13574/zed
that referenced
this pull request
Dec 16, 2025
Sometimes machines are configured to drop outbound packets (rather than reject connections). In these cases, curl/wget just hang causing our download step to never complete. This PR adds a timeout of 10s for the connection (not the whole download), so that in situations like this we can fallback to our client-side download eventually. Related to but doesn't fully fix: zed-industries#43694 and zed-industries#43718 Release Notes: - remote: Add 10s connect timeout for server download
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes machines are configured to drop outbound packets (rather than reject connections). In these cases, curl/wget just hang causing our download step to never complete. This PR adds a timeout of 10s for the connection (not the whole download), so that in situations like this we can fallback to our client-side download eventually.
Related to but doesn't fully fix: #43694 and #43718
Release Notes: