remote: Use last line of uname and shell output#44165
Merged
Conversation
Contributor
Contributor
Author
|
re danger: this PR does not close the whole issue, it just addresses something the user mentioned |
3d6ac9a to
06ca026
Compare
Veykril
approved these changes
Dec 5, 2025
Member
Veykril
left a comment
There was a problem hiding this comment.
Yea we should've done this from the start after all. We'll need to do the same for WSL as well I think
Contributor
Author
|
/cherry-pick preview |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 5, 2025
We have seen cases (see #43694) where the user's shell initialization script includes text that ends up in the output of the commands we use to detect the platform and shell of the remote. This solution isn't perfect, but it should address the issue in most situations since both commands should only output one line. Release Notes: - remote: Improve resiliency when initialization scripts output text
zed-zippy bot
added a commit
that referenced
this pull request
Dec 5, 2025
…ck to preview) (#44220) Cherry-pick of #44165 to preview ---- We have seen cases (see #43694) where the user's shell initialization script includes text that ends up in the output of the commands we use to detect the platform and shell of the remote. This solution isn't perfect, but it should address the issue in most situations since both commands should only output one line. Release Notes: - remote: Improve resiliency when initialization scripts output text Co-authored-by: Agus Zubiaga <agus@zed.dev>
AlpSha
pushed a commit
to AlpSha/zed
that referenced
this pull request
Dec 5, 2025
We have seen cases (see zed-industries#43694) where the user's shell initialization script includes text that ends up in the output of the commands we use to detect the platform and shell of the remote. This solution isn't perfect, but it should address the issue in most situations since both commands should only output one line. Release Notes: - remote: Improve resiliency when initialization scripts output text
This was referenced Dec 8, 2025
CherryWorm
pushed a commit
to CherryWorm/zed
that referenced
this pull request
Dec 16, 2025
We have seen cases (see zed-industries#43694) where the user's shell initialization script includes text that ends up in the output of the commands we use to detect the platform and shell of the remote. This solution isn't perfect, but it should address the issue in most situations since both commands should only output one line. Release Notes: - remote: Improve resiliency when initialization scripts output text
CherryWorm
pushed a commit
to CherryWorm/zed
that referenced
this pull request
Dec 16, 2025
…l scripts (zed-industries#44363) Companion PR to zed-industries#44165 Release Notes: - N/A *or* Added/Fixed/Improved ...
someone13574
pushed a commit
to someone13574/zed
that referenced
this pull request
Dec 16, 2025
We have seen cases (see zed-industries#43694) where the user's shell initialization script includes text that ends up in the output of the commands we use to detect the platform and shell of the remote. This solution isn't perfect, but it should address the issue in most situations since both commands should only output one line. Release Notes: - remote: Improve resiliency when initialization scripts output text
someone13574
pushed a commit
to someone13574/zed
that referenced
this pull request
Dec 16, 2025
…l scripts (zed-industries#44363) Companion PR to zed-industries#44165 Release Notes: - N/A *or* Added/Fixed/Improved ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have seen cases (see #43694) where the user's shell initialization script includes text that ends up in the output of the commands we use to detect the platform and shell of the remote. This solution isn't perfect, but it should address the issue in most situations since both commands should only output one line.
Release Notes: