gpui: Fix division by zero crash#44151
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @rawandahmad698 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
1 similar comment
|
We require contributors to sign our Contributor License Agreement, and we don't have @rawandahmad698 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@rawandahmad698 Thank you for your contribution! Have you signed the CLA by clicking "I agree with Zed's CLA" at the bottom of https://zed.dev/cla? |
Appreciate it. I have now. |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
/cherry-pick preview |
Closes #44148 the existing rate == 0 check inside the timer callback already handles disabling repeat - it just drops the timer immediately. So the fix prevents the crash while preserving correct behavior. Release Notes: - Linux (Wayland): Fixed a crash that could occur when `characters_per_second` was zero
|
/cherry-pick stable |
|
🍒💥 Cherry-pick did not succeed |
…erry-pick to preview) (#44154) Cherry-pick of #44151 to preview ---- Closes #44148 the existing rate == 0 check inside the timer callback already handles disabling repeat - it just drops the timer immediately. So the fix prevents the crash while preserving correct behavior. Release Notes: - Linux (Wayland): Fixed a crash that could occur when `characters_per_second` was zero Co-authored-by: Rawand Ahmed Shaswar <rawandahmad698@gmail.com>
…ies#44151) Closes zed-industries#44148 the existing rate == 0 check inside the timer callback already handles disabling repeat - it just drops the timer immediately. So the fix prevents the crash while preserving correct behavior. Release Notes: - Linux (Wayland): Fixed a crash that could occur when `characters_per_second` was zero
…ies#44151) Closes zed-industries#44148 the existing rate == 0 check inside the timer callback already handles disabling repeat - it just drops the timer immediately. So the fix prevents the crash while preserving correct behavior. Release Notes: - Linux (Wayland): Fixed a crash that could occur when `characters_per_second` was zero
…ies#44151) Closes zed-industries#44148 the existing rate == 0 check inside the timer callback already handles disabling repeat - it just drops the timer immediately. So the fix prevents the crash while preserving correct behavior. Release Notes: - Linux (Wayland): Fixed a crash that could occur when `characters_per_second` was zero
Closes #44148
the existing rate == 0 check inside the timer callback already handles disabling repeat - it just drops the timer immediately. So the fix prevents the crash while preserving correct behavior. This is my first contribution, so if it is not the right solution all feedback is appreciated
Release Notes:
characters_per_secondwas zero