Skip to content

commit view: Display message within editor#44024

Merged
agu-z merged 3 commits intomainfrom
commit-header-tweaks
Dec 2, 2025
Merged

commit view: Display message within editor#44024
agu-z merged 3 commits intomainfrom
commit-header-tweaks

Conversation

@agu-z
Copy link
Contributor

@agu-z agu-z commented Dec 2, 2025

#42441 moved the commit message out of the multi-buffer editor into its own header element which looks nicer, but unfortunately can make the view become unusable when the commit message is too long since it doesn't scroll with the diff.

This PR maintains the metadata in its own element, but moves the commit message back to the editor so the user can scroll past it. This does mean that we lose markdown rendering for now, but we think this is a good solution for the moment.

CleanShot.2025-12-02.at.19.26.14.mp4

We also improved the avatar fallback and made sure the text aligned with the gutter.

Release Notes:

  • N/A

agu-z and others added 2 commits December 2, 2025 18:42
Co-authored-by: cameron <cameron.studdstreet@gmail.com>
Co-authored-by: cameron <cameron.studdstreet@gmail.com>
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 2, 2025
@agu-z agu-z enabled auto-merge (squash) December 2, 2025 22:22
@agu-z agu-z merged commit 8a12ecf into main Dec 2, 2025
25 checks passed
@agu-z agu-z deleted the commit-header-tweaks branch December 2, 2025 22:30
CherryWorm pushed a commit to CherryWorm/zed that referenced this pull request Dec 16, 2025
zed-industries#42441 moved the commit message out of the multi-buffer editor into its
own header element which looks nicer, but unfortunately can make the
view become unusable when the commit message is too long since it
doesn't scroll with the diff.

This PR maintains the metadata in its own element, but moves the commit
message back to the editor so the user can scroll past it. This does
mean that we lose markdown rendering for now, but we think this is a
good solution for the moment.


https://github.com/user-attachments/assets/d67cf22e-1a79-451a-932a-cdc8a65e43de

Release Notes:

- N/A

---------

Co-authored-by: cameron <cameron.studdstreet@gmail.com>
someone13574 pushed a commit to someone13574/zed that referenced this pull request Dec 16, 2025
zed-industries#42441 moved the commit message out of the multi-buffer editor into its
own header element which looks nicer, but unfortunately can make the
view become unusable when the commit message is too long since it
doesn't scroll with the diff.

This PR maintains the metadata in its own element, but moves the commit
message back to the editor so the user can scroll past it. This does
mean that we lose markdown rendering for now, but we think this is a
good solution for the moment.


https://github.com/user-attachments/assets/d67cf22e-1a79-451a-932a-cdc8a65e43de

Release Notes:

- N/A

---------

Co-authored-by: cameron <cameron.studdstreet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant