gpui(windows): Move interior mutability down into fields#44002
Merged
Conversation
CherryWorm
pushed a commit
to CherryWorm/zed
that referenced
this pull request
Dec 16, 2025
…ies#44002) Windows applications tend to be fairly re-entrant which does not work well with our current top-level `RefCell` approach. We have worked around a bunch of panics in the past due to this, but ultimately this will re-occur (and still does according to sentry) in the future. So this PR moves all interior mutability down to the fields. Fixes ZED-1HM Fixes ZED-3SH Fixes ZED-1YV Fixes ZED-29S Fixes ZED-29X Fixes ZED-369 Fixes ZED-20W Release Notes: - Fixed panics on windows caused by unexpected re-entrancy for interior mutability
someone13574
pushed a commit
to someone13574/zed
that referenced
this pull request
Dec 16, 2025
…ies#44002) Windows applications tend to be fairly re-entrant which does not work well with our current top-level `RefCell` approach. We have worked around a bunch of panics in the past due to this, but ultimately this will re-occur (and still does according to sentry) in the future. So this PR moves all interior mutability down to the fields. Fixes ZED-1HM Fixes ZED-3SH Fixes ZED-1YV Fixes ZED-29S Fixes ZED-29X Fixes ZED-369 Fixes ZED-20W Release Notes: - Fixed panics on windows caused by unexpected re-entrancy for interior mutability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows applications tend to be fairly re-entrant which does not work well with our current top-level
RefCellapproach. We have worked around a bunch of panics in the past due to this, but ultimately this will re-occur (and still does according to sentry) in the future. So this PR moves all interior mutability down to the fields.Fixes ZED-1HM
Fixes ZED-3SH
Fixes ZED-1YV
Fixes ZED-29S
Fixes ZED-29X
Fixes ZED-369
Fixes ZED-20W
Release Notes: