agent_ui: Fix delete icon event in history panel#43796
Merged
danilo-leal merged 1 commit intozed-industries:mainfrom Nov 29, 2025
Merged
agent_ui: Fix delete icon event in history panel#43796danilo-leal merged 1 commit intozed-industries:mainfrom
danilo-leal merged 1 commit intozed-industries:mainfrom
Conversation
- Stop event propagation in thread removal handler
Contributor
Author
|
:) Yep
…On Sat, Nov 29, 2025 at 10:14 PM Danilo Leal ***@***.***> wrote:
***@***.**** approved this pull request.
Thank you!
—
Reply to this email directly, view it on GitHub
<#43796 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVCEW6F3ZCPDSYKVOM3IUD37GS3ZAVCNFSM6AAAAACNRKKYPOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKMRQG4YTMOBYHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
11happy
pushed a commit
to 11happy/zed
that referenced
this pull request
Dec 1, 2025
Summary Fixed the thread deletion issue by: 1. Click handler conflict between the trash icon and the main ListItem 2. Added `cx.stop_propagation()` to prevent the click event from bubbling up to the parent ListItem's click handler 3. Followed the established `cx.stop_propagation()` pattern used throughout the codebase Now when you click the trash icon to delete a thread: - ✅ The thread deletion happens immediately on the first click - ✅ No race condition between deletion and activation - ✅ No double-clicking required The fix is minimal, follows established patterns, and addresses the exact root cause of the issue. - Stop event propagation in thread removal handler Release Notes: - agent: Improved delete thread action in the history view by preventing it from also triggering the thread activation.
someone13574
pushed a commit
to someone13574/zed
that referenced
this pull request
Dec 16, 2025
Summary Fixed the thread deletion issue by: 1. Click handler conflict between the trash icon and the main ListItem 2. Added `cx.stop_propagation()` to prevent the click event from bubbling up to the parent ListItem's click handler 3. Followed the established `cx.stop_propagation()` pattern used throughout the codebase Now when you click the trash icon to delete a thread: - ✅ The thread deletion happens immediately on the first click - ✅ No race condition between deletion and activation - ✅ No double-clicking required The fix is minimal, follows established patterns, and addresses the exact root cause of the issue. - Stop event propagation in thread removal handler Release Notes: - agent: Improved delete thread action in the history view by preventing it from also triggering the thread activation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the thread deletion issue by:
cx.stop_propagation()to prevent the click event from bubbling up to the parent ListItem's click handlercx.stop_propagation()pattern used throughout the codebaseNow when you click the trash icon to delete a thread:
The fix is minimal, follows established patterns, and addresses the exact root cause of the issue.
Release Notes: