Implement select_line and split_selection_into_lines#43
Merged
Conversation
Fold ranges are exclusive, exactly like the query ranges. So if the end of a fold coincides with the start of the query range, we shouldn't report that fold. Analogously, if the start of a fold coincides with the end of the query range, that fold shouldn't be reported.
bbutkovic
pushed a commit
to bbutkovic/zed
that referenced
this pull request
Oct 4, 2024
* Use buffer settings for font, size etc. * Trim end of message * By default send the output values to the output editor * WIP send evaluate request * Rename variable * Add result to console from evaluate response * Remove not needed arc * Remove store capabilities on variable_list * Specify the capacity for the task vec * Add placeholder * WIP add completion provider for existing variables * Add value to auto completion label * Make todo for debugger * Specify the capacity of the vec's * Make clippy happy * Remove not needed notifies and add missing one * WIP move scopes and variables to variable_list * Rename configuration done method * Add support for adapter completions and manual variable completions * Move type to variabel_list * Change update to read * Show debug panel when debug session stops Co-Authored-By: Anthony Eid <56899983+Anthony-Eid@users.noreply.github.com> Co-Authored-By: Mikayla Maki <mikayla.c.maki@gmail.com> * Also use scope reference to determine to which where the set value editor should display * Refetch existing variables after * Rebuild entries after refetching the variables --------- Co-authored-by: Anthony Eid <56899983+Anthony-Eid@users.noreply.github.com> Co-authored-by: Mikayla Maki <mikayla.c.maki@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #25
As per the pull request's title, with these changes Zed now understands two new commands:
buffer_view:select_line(bound tocmd-l)buffer_view:split_selection_into_lines(bound tocmd-shift-l)Note that in 1c2f549 I slightly changed the behavior of fold intersection queries to be more precise with respect to the endpoints of the given range (see the commit for more details).
/cc: @nathansobo @maxbrunsfeld