Conversation
will never match an inclusion/exclusion query. Co-authored-by: dino <dinojoaocosta@gmail.com>
e271410 to
6915601
Compare
osiewicz
commented
Nov 18, 2025
smitbarmase
approved these changes
Nov 18, 2025
Member
Author
|
Our tests found an issue with a scenario where we have:
Exclusion pattern will prune files before we even get to loading the |
osiewicz
commented
Nov 18, 2025
Member
Author
There was a problem hiding this comment.
IMHO these tests could reside in project_search.rs.
mikayla-maki
pushed a commit
that referenced
this pull request
Nov 20, 2025
…ts will never match an inclusion/exclusion query (#42968) Co-authored-by: dino <dinojoaocosta@gmail.com> Related-to: #38799 Release Notes: - Improved project search performance with "Also search files ignored by configuration" combined with file inclusion/exclusion queries. --------- Co-authored-by: dino <dinojoaocosta@gmail.com>
11happy
pushed a commit
to 11happy/zed
that referenced
this pull request
Dec 1, 2025
…ts will never match an inclusion/exclusion query (zed-industries#42968) Co-authored-by: dino <dinojoaocosta@gmail.com> Related-to: zed-industries#38799 Release Notes: - Improved project search performance with "Also search files ignored by configuration" combined with file inclusion/exclusion queries. --------- Co-authored-by: dino <dinojoaocosta@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: dino dinojoaocosta@gmail.com
Related-to: #38799
Release Notes: