terminal_view: Fix terminal opening in root directory when editing single file corktree#42953
Merged
Veykril merged 1 commit intozed-industries:mainfrom Nov 18, 2025
Conversation
Fixes zed-industries#42945 When opening a single file via command line, the terminal was opening in root directory instead of the file's directory. This fix adds fallback logic and makes first_project_directory return the parent directory for file worktrees.
|
We require contributors to sign our Contributor License Agreement, and we don't have @canack on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
Contributor
Contributor
Author
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
11happy
pushed a commit
to 11happy/zed
that referenced
this pull request
Dec 1, 2025
…ngle file corktree (zed-industries#42953) Fixes zed-industries#42945 ## Problem When opening a single file via command line (e.g., `zed ~/Downloads/file.txt`), the terminal panel was opening in the root directory (/) instead of the file's directory. ## Root Cause The code only checked for active project directory, which returns None when a single file is opened. Additionally, file worktrees weren't handling parent directory lookup. ## Solution Added fallback logic to use the first project directory when there's no active entry, and made file worktrees return their parent directory instead of None. ## Testing - All existing tests pass - Added test coverage for file worktree scenarios - Manually tested with `zed ~/Downloads/file.txt` - terminal now opens in correct directory This improves the user experience for users who frequently open single files from the command line. ## Release Notes - Fixed terminal opening in root directory when editing single files from the command line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42945
Problem
When opening a single file via command line (e.g.,
zed ~/Downloads/file.txt), the terminal panel was opening in the root directory (/) instead of the file's directory.Root Cause
The code only checked for active project directory, which returns None when a single file is opened. Additionally, file worktrees weren't handling parent directory lookup.
Solution
Added fallback logic to use the first project directory when there's no active entry, and made file worktrees return their parent directory instead of None.
Testing
zed ~/Downloads/file.txt- terminal now opens in correct directoryThis improves the user experience for users who frequently open single files from the command line.
Release Notes