Skip to content

settings_ui: Add "Edit in settings.json" button to subpage header#42886

Merged
danilo-leal merged 3 commits intomainfrom
settings-ui-edit-in-json-btn
Nov 17, 2025
Merged

settings_ui: Add "Edit in settings.json" button to subpage header#42886
danilo-leal merged 3 commits intomainfrom
settings-ui-edit-in-json-btn

Conversation

@danilo-leal
Copy link
Member

Closes #42094

This will make it consistent with the regular/main page. Also ended up fixing a bug along the way where this button wouldn't work for subpage items.

Release Notes:

  • settings ui: Fixed a bug where the "Edit in settings.json" wouldn't work for subpages like all the Language pages.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Nov 17, 2025
@danilo-leal danilo-leal merged commit bb46bc1 into main Nov 17, 2025
23 checks passed
@danilo-leal danilo-leal deleted the settings-ui-edit-in-json-btn branch November 17, 2025 14:58
11happy pushed a commit to 11happy/zed that referenced this pull request Dec 1, 2025
…d-industries#42886)

Closes zed-industries#42094

This will make it consistent with the regular/main page. Also ended up
fixing a bug along the way where this button wouldn't work for subpage
items.

Release Notes:

- settings ui: Fixed a bug where the "Edit in settings.json" wouldn't
work for subpages like all the Language pages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "Edit in settings.json" button for each language's settings view

1 participant