keymap_editor: Make "toggle exact match mode" the default for binding search#42883
Merged
danilo-leal merged 2 commits intomainfrom Nov 17, 2025
Merged
keymap_editor: Make "toggle exact match mode" the default for binding search#42883danilo-leal merged 2 commits intomainfrom
danilo-leal merged 2 commits intomainfrom
Conversation
11happy
pushed a commit
to 11happy/zed
that referenced
this pull request
Dec 1, 2025
… search (zed-industries#42883) I think having the "exact mode" turned on by default is usually what users will expect when searching for a specific keybinding. When it's turned off, it's very odd to search for a super common binding like "command-enter" and get no results. That happens because without that mode, we're trying to match for subsequent matches, which I'm betting it's an edge case. Hopefully, this change will make the keymap editor feel more like it works well. I'm also adding the toggle icon button inside the keystroke input for consistency with the project search input. Making this change very inspired by [Sam Rose's feedback](https://bsky.app/profile/samwho.dev/post/3m5juszqyd22w). Release Notes: - keymap editor: Made the "toggle exact match mode" the default keystroke search mode so that whatever you search for matches exactly to results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think having the "exact mode" turned on by default is usually what users will expect when searching for a specific keybinding. When it's turned off, it's very odd to search for a super common binding like "command-enter" and get no results. That happens because without that mode, we're trying to match for subsequent matches, which I'm betting it's an edge case. Hopefully, this change will make the keymap editor feel more like it works well.
I'm also adding the toggle icon button inside the keystroke input for consistency with the project search input.
Making this change very inspired by Sam Rose's feedback.
Release Notes: