git_ui: Fix tooltip overlaying context menu in git blame#42764
Merged
MrSubidubi merged 4 commits intozed-industries:mainfrom Dec 8, 2025
Merged
git_ui: Fix tooltip overlaying context menu in git blame#42764MrSubidubi merged 4 commits intozed-industries:mainfrom
MrSubidubi merged 4 commits intozed-industries:mainfrom
Conversation
6639835
approved these changes
Nov 15, 2025
MrSubidubi
requested changes
Nov 25, 2025
Member
MrSubidubi
left a comment
There was a problem hiding this comment.
Thanks for this.
While this is definitely an approach to fix this, this effectively eliminates the ability to have tooltips in deferred draws, does it not? So I doubt this is the proper fix for this.
Additionally, it seems the tooltip can get both stale and annoying, especially once the context menu is deployed. Feels like the approach in the other PR might be more sensible to approach?
|
@amustaque97 hi! We have a few pairing sessions still available this week if you want to chat with the team and work through some of the feedback above: https://cal.com/esther-trapadoux-zed/30min |
8c77592 to
831dc98
Compare
MrSubidubi
requested changes
Dec 3, 2025
Co-authored-by: Finn Evers <finn.evers@outlook.de>
MrSubidubi
reviewed
Dec 3, 2025
Co-authored-by: Finn Evers <finn.evers@outlook.de>
MrSubidubi
requested changes
Dec 8, 2025
Member
MrSubidubi
left a comment
There was a problem hiding this comment.
Nice, this looks very good now. Thank you!
MrSubidubi
approved these changes
Dec 8, 2025
CherryWorm
pushed a commit
to CherryWorm/zed
that referenced
this pull request
Dec 16, 2025
…ies#42764) Closes zed-industries#26949 ## Summary 1. Split editor references to avoid borrow conflicts in event handlers 2. Check [has_mouse_context_menu()](vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-browser/workbench/workbench.html) state directly in tooltip conditional instead of caching stale value 3. Restructured context menu deployment to ensure proper sequencing: hide popover → build menu → deploy menu → notify for re-render **Screen recording** https://github.com/user-attachments/assets/8a00f882-1c54-47b0-9211-4f28f8deb867 Release Notes: - Fixed an issue where the context menu in the Git Blame view would be frequently overlapped by the commit information tooltip. --------- Co-authored-by: Finn Evers <finn.evers@outlook.de>
someone13574
pushed a commit
to someone13574/zed
that referenced
this pull request
Dec 16, 2025
…ies#42764) Closes zed-industries#26949 ## Summary 1. Split editor references to avoid borrow conflicts in event handlers 2. Check [has_mouse_context_menu()](vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-browser/workbench/workbench.html) state directly in tooltip conditional instead of caching stale value 3. Restructured context menu deployment to ensure proper sequencing: hide popover → build menu → deploy menu → notify for re-render **Screen recording** https://github.com/user-attachments/assets/8a00f882-1c54-47b0-9211-4f28f8deb867 Release Notes: - Fixed an issue where the context menu in the Git Blame view would be frequently overlapped by the commit information tooltip. --------- Co-authored-by: Finn Evers <finn.evers@outlook.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #26949
Summary
Screen recording
Screen.Recording.2025-12-03.at.6.39.19.PM.mov
Release Notes: