Skip to content

lsp_button: Do not surface language servers from different windows in current workspace#42733

Merged
HactarCE merged 4 commits intomainfrom
42077-remove-cross-window-servers
Nov 19, 2025
Merged

lsp_button: Do not surface language servers from different windows in current workspace#42733
HactarCE merged 4 commits intomainfrom
42077-remove-cross-window-servers

Conversation

@osiewicz
Copy link
Member

@osiewicz osiewicz commented Nov 14, 2025

This led to a problem where we'd have a zombie entries in LSP dropdown
because they were treated as if they originated from an unknown
worktree.

Co-authored-by: HactarCE 6060305+HactarCE@users.noreply.github.com

Closes #42077

Release Notes:

  • Fixed LSP status list containing zombie entries for LSPs in other windows

current workspace

This led to a problem where we'd have a zombie entries in LSP dropdown
because they were treated as if they originated from an unknown
worktree.

Co-authored-by: HactarCE <6060305+HactarCE@users.noreply.github.com>
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Nov 14, 2025
@HactarCE
Copy link
Contributor

HactarCE commented Nov 17, 2025

I reached out to @SomeoneToIgnore and he says he's not sure on this. We'll pair on it in the next day or two.

@HactarCE HactarCE enabled auto-merge (squash) November 19, 2025 22:04
@HactarCE HactarCE merged commit c70f2d1 into main Nov 19, 2025
36 of 38 checks passed
@HactarCE HactarCE deleted the 42077-remove-cross-window-servers branch November 19, 2025 22:40
@maxbrunsfeld
Copy link
Collaborator

Thank you for fixing this!

mikayla-maki pushed a commit that referenced this pull request Nov 20, 2025
… current workspace (#42733)

This led to a problem where we'd have a zombie entries in LSP dropdown
because they were treated as if they originated from an unknown
worktree.

Closes #42077

Release Notes:

- Fixed LSP status list containing zombie entries for LSPs in other
windows

---------

Co-authored-by: HactarCE <6060305+HactarCE@users.noreply.github.com>
Co-authored-by: Kirill Bulatov <kirill@zed.dev>
11happy pushed a commit to 11happy/zed that referenced this pull request Dec 1, 2025
… current workspace (zed-industries#42733)

This led to a problem where we'd have a zombie entries in LSP dropdown
because they were treated as if they originated from an unknown
worktree.

Closes zed-industries#42077

Release Notes:

- Fixed LSP status list containing zombie entries for LSPs in other
windows

---------

Co-authored-by: HactarCE <6060305+HactarCE@users.noreply.github.com>
Co-authored-by: Kirill Bulatov <kirill@zed.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should close all the language server after that instance of zed is closed.

3 participants