Fix remote server completions not being queried from all LSP servers#42723
Merged
Fix remote server completions not being queried from all LSP servers#42723
Conversation
Collaborator
maxbrunsfeld
left a comment
There was a problem hiding this comment.
Looks great. Could you add a test for this as well? Possible places for the test:
One would test the remoteing version, and one would test the same thing, but over collaboration. It's mostly the same code path, but the collab one is mediated by the collab server. It would be good to check that the collaboration case works as well - if it doesn't, it's likely a pretty small change to get it to work.
Collaborator
|
Nice! Thank you |
|
holly sh** its happening guys!!!! (this is a big deal for me, it finally enables switching from vscode to zed. thanks for your work @localcc !) |
11happy
pushed a commit
to 11happy/zed
that referenced
this pull request
Dec 1, 2025
…ed-industries#42723) Closes zed-industries#41294 Release Notes: - Fixed remote LSPs not being queried
This was referenced Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #41294
Release Notes: