Helix: Fix visual/textual line up/down#42676
Merged
kubkon merged 2 commits intozed-industries:mainfrom Dec 15, 2025
Merged
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @probablykasper on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
The cla-bot has been summoned, and re-checked this pull request! |
Contributor
Author
|
@kubkon Hey, got time to merge this little PR? |
Member
Yep, sorry about the delay - was away the past two weeks. Anyhow, changes look great, thanks! I've re-triggered tests so that we get the green light from the CI, and proceed with the merge! |
CherryWorm
pushed a commit
to CherryWorm/zed
that referenced
this pull request
Dec 16, 2025
Release Notes: - Make Helix keybinds use visual line movement for `j`, `Down`, `k` and `Up`, and textual line movement for `g j`, `g Down`, `g k` and `g Up`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress on #4642
Fixes the Helix keybinds to use visual line up/down movement by default (and
gmode for textual movement). Source: https://docs.helix-editor.com/keymap.htmlHaven't been able to test it because
webrtc-sysfails to compile for me (macOS x64):Release Notes:
j,Down,kandUpuse visual movement, and textual line movement forg j,g Down,g kandg Up.