Skip to content

Helix: Fix visual/textual line up/down#42676

Merged
kubkon merged 2 commits intozed-industries:mainfrom
probablykasper:helix-updown
Dec 15, 2025
Merged

Helix: Fix visual/textual line up/down#42676
kubkon merged 2 commits intozed-industries:mainfrom
probablykasper:helix-updown

Conversation

@probablykasper
Copy link
Contributor

@probablykasper probablykasper commented Nov 13, 2025

Progress on #4642

Fixes the Helix keybinds to use visual line up/down movement by default (and g mode for textual movement). Source: https://docs.helix-editor.com/keymap.html

Haven't been able to test it because webrtc-sys fails to compile for me (macOS x64):

/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.2.sdk/usr/include/c++/v1/__memory/pointer_traits.h:118:22: error: implicit instantiation of undefined template 'std::__pointer_traits_element_type<rust::Slice::iterator>'

Release Notes:

  • Make Helix keybinds use visual line movement for j, Down, k and Up use visual movement, and textual line movement for g j, g Down, g k and g Up.

@cla-bot
Copy link

cla-bot bot commented Nov 13, 2025

We require contributors to sign our Contributor License Agreement, and we don't have @probablykasper on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Nov 13, 2025
@cla-bot
Copy link

cla-bot bot commented Nov 13, 2025

The cla-bot has been summoned, and re-checked this pull request!

@probablykasper
Copy link
Contributor Author

@kubkon Hey, got time to merge this little PR?

@kubkon
Copy link
Member

kubkon commented Dec 15, 2025

@kubkon Hey, got time to merge this little PR?

Yep, sorry about the delay - was away the past two weeks. Anyhow, changes look great, thanks! I've re-triggered tests so that we get the green light from the CI, and proceed with the merge!

@kubkon kubkon enabled auto-merge (squash) December 15, 2025 10:25
@kubkon kubkon merged commit c996934 into zed-industries:main Dec 15, 2025
23 checks passed
@github-project-automation github-project-automation bot moved this from Community PRs to Done in Quality Week – December 2025 Dec 15, 2025
@probablykasper probablykasper deleted the helix-updown branch December 15, 2025 23:10
CherryWorm pushed a commit to CherryWorm/zed that referenced this pull request Dec 16, 2025
Release Notes:

- Make Helix keybinds use visual line movement for `j`, `Down`, `k` and `Up`, and textual line movement for `g j`, `g Down`, `g k` and `g Up`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

Development

Successfully merging this pull request may close these issues.

2 participants