settings_ui: Make open project settings action open settings UI#42669
Merged
Anthony-Eid merged 2 commits intomainfrom Nov 14, 2025
Merged
settings_ui: Make open project settings action open settings UI#42669Anthony-Eid merged 2 commits intomainfrom
Anthony-Eid merged 2 commits intomainfrom
Conversation
11happy
pushed a commit
to 11happy/zed
that referenced
this pull request
Dec 1, 2025
…industries#42669) This PR makes the `OpenProjectSettings` action open the settings UI in project settings mode for the first visible worktree, instead of opening the file. It also adds a `OpenProjectSettingsFile` action that maintains the old behavior. Finally, this PR partially fixes a bug where the settings UI won't load project settings when the settings window is loaded before opening a project/workspace. This happens because the global `app_state` isn't correct in the `Subscription` that refreshes the available setting files to open. The bug is still present in some cases, but it's out of scope for this PR. Release Notes: - settings ui: Project Settings action now opens settings UI instead of a file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the
OpenProjectSettingsaction open the settings UI in project settings mode for the first visible worktree, instead of opening the file. It also adds aOpenProjectSettingsFileaction that maintains the old behavior.Finally, this PR partially fixes a bug where the settings UI won't load project settings when the settings window is loaded before opening a project/workspace. This happens because the global
app_stateisn't correct in theSubscriptionthat refreshes the available setting files to open. The bug is still present in some cases, but it's out of scope for this PR.Release Notes: