Skip to content

editor: Improve multi-buffer header filename click to jump to the latest selection from that buffer#42480

Merged
smitbarmase merged 5 commits intomainfrom
fix-buffer-header-button-clicks
Nov 11, 2025
Merged

editor: Improve multi-buffer header filename click to jump to the latest selection from that buffer#42480
smitbarmase merged 5 commits intomainfrom
fix-buffer-header-button-clicks

Conversation

@smitbarmase
Copy link
Member

@smitbarmase smitbarmase commented Nov 11, 2025

Closes #42099

Regressed in #42283

Release Notes:

  • Clicking the multi-buffer header file name or the "Open file" button now jumps to the most recent selection in that buffer, if one exists.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Nov 11, 2025
@smitbarmase smitbarmase merged commit b4b7a23 into main Nov 11, 2025
39 of 41 checks passed
@smitbarmase smitbarmase deleted the fix-buffer-header-button-clicks branch November 11, 2025 20:34
smitbarmase added a commit that referenced this pull request Nov 12, 2025
… the latest selection from that buffer" (#42534)

Reverts #42480

This panics on Nightly in cases where anchor might not be valid for that
snapshot. Taking it back before the cutoff.

Release Notes:

- N/A
smitbarmase added a commit that referenced this pull request Nov 13, 2025
…est selection from that buffer - take 2 (#42613)

Relands #42480

Release Notes:

- Clicking the multi-buffer header file name or the "Open file" button
now jumps to the most recent selection in that buffer, if one exists.

---------

Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com>
11happy pushed a commit to 11happy/zed that referenced this pull request Dec 1, 2025
…est selection from that buffer (zed-industries#42480)

Closes zed-industries#42099

Regressed in zed-industries#42283

Release Notes:

- Clicking the multi-buffer header file name or the "Open file" button
now jumps to the most recent selection in that buffer, if one exists.
11happy pushed a commit to 11happy/zed that referenced this pull request Dec 1, 2025
… the latest selection from that buffer" (zed-industries#42534)

Reverts zed-industries#42480

This panics on Nightly in cases where anchor might not be valid for that
snapshot. Taking it back before the cutoff.

Release Notes:

- N/A
11happy pushed a commit to 11happy/zed that referenced this pull request Dec 1, 2025
…est selection from that buffer - take 2 (zed-industries#42613)

Relands zed-industries#42480

Release Notes:

- Clicking the multi-buffer header file name or the "Open file" button
now jumps to the most recent selection in that buffer, if one exists.

---------

Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant