Add QuitMode policy to GPUI#42391
Merged
reflectronic merged 1 commit intozed-industries:mainfrom Nov 10, 2025
Merged
Conversation
MrSubidubi
added a commit
that referenced
this pull request
Nov 19, 2025
Follow-up to #42391 Release Notes: - Fixed an issue where Zed did not respect the `on_last_window_closed` setting on macOS
github-actions bot
pushed a commit
that referenced
this pull request
Nov 19, 2025
Follow-up to #42391 Release Notes: - Fixed an issue where Zed did not respect the `on_last_window_closed` setting on macOS
mikayla-maki
pushed a commit
that referenced
this pull request
Nov 20, 2025
Follow-up to #42391 Release Notes: - Fixed an issue where Zed did not respect the `on_last_window_closed` setting on macOS
|
@reflectronic May I ask why the default quit mode is different for MacOS? Doesn't that mean that when I leave the quit mode as |
Member
Author
I think the expectation for many types of apps on macOS is that they only exit when the user runs the "Quit" command. This was also the behavior in GPUI before the refactoring in #41436. This patch is just restoring the existing behavior. |
11happy
pushed a commit
to 11happy/zed
that referenced
this pull request
Dec 1, 2025
Applications can select a policy for when the app quits using the new function `Application::with_quit_mode`: - Only on explicit calls to `App::quit` - When the last window is closed - Platform default (former on macOS, latter everywhere else) Release Notes: - N/A
11happy
pushed a commit
to 11happy/zed
that referenced
this pull request
Dec 1, 2025
Follow-up to zed-industries#42391 Release Notes: - Fixed an issue where Zed did not respect the `on_last_window_closed` setting on macOS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applications can select a policy for when the app quits using the new function
Application::with_quit_mode:App::quitRelease Notes: