agent: Clarify include_pattern parameter usage for grep tool#41225
Merged
rtfeldman merged 1 commit intozed-industries:mainfrom Nov 28, 2025
Merged
agent: Clarify include_pattern parameter usage for grep tool#41225rtfeldman merged 1 commit intozed-industries:mainfrom
include_pattern parameter usage for grep tool#41225rtfeldman merged 1 commit intozed-industries:mainfrom
Conversation
Contributor
Author
|
@rtfeldman what happens next, do I need to update the release notes like the bot suggests? |
auto-merge was automatically disabled
November 21, 2025 09:08
Head branch was pushed to by a user without write access
Contributor
Author
|
@rtfeldman I rebased it to main to force checks to be actually run now and added Release notes section to the PR. I still encounter this bug daily. |
11happy
pushed a commit
to 11happy/zed
that referenced
this pull request
Dec 1, 2025
…ndustries#41225) Adds clarifying examples and information about the `include_pattern` parameter for the grep tool, analogous to the `path` parameter of the read and list tools and others. The lack of clarity led to unexpected agent behavior described in zed-industries#41189. This change is confirmed to improve the precision of Claude Sonnet 4.5 when searching for code in an empty conversation (without it, it leaves out the root directory in the query). Closes zed-industries#41189. ``` Release Notes: - Clarify grep tool description to improve agent precision when using it with the `include_pattern` parameter ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds clarifying examples and information about the
include_patternparameter for the grep tool, analogous to thepathparameter of the read and list tools and others.The lack of clarity led to unexpected agent behavior described in #41189. This change is confirmed to improve the precision of Claude Sonnet 4.5 when searching for code in an empty conversation (without it, it leaves out the root directory in the query).
Closes #41189.