Update runtimed to fix compatibility issue with the Ark kernel by lionel- · Pull Request #40889 · zed-industries/zed

lionel- · 2025-10-22T12:37:41Z

This updates runtimed to the latest version, which handles the "starting" variant of execution_state. It actually handles a bunch of other variants that are not documented in the protocol (see https://jupyter-client.readthedocs.io/en/stable/messaging.html#kernel-status), like "starting", "terminating", etc. I added implementations for these variants as well.

Release Notes:

Fixed issue that prevented the Ark kernel from working in Zed (Jupyter client can't unserialise status message with "starting" execution_state #40888).

lionel- · 2025-10-22T12:38:31Z

crates/client/src/client.rs

                request_headers.insert("x-zed-metrics-id", HeaderValue::from_str(&metrics_id)?);
            }

+            #[cfg(any(target_os = "windows", target_os = "macos"))]


A build issue appeared with the update.

I don't understand the details here, but I fixed it following existing code at

zed/crates/client/src/proxy/http_proxy.rs

Lines 67 to 98 in 14b41b1

#[cfg(any(target_os = "windows", target_os = "macos"))]

async fn https_connect<T>(

stream: T,

target: (&str, u16),

auth: Option<HttpProxyAuthorization<'_>>,

proxy_domain: &str,

) -> Result<Box<dyn AsyncReadWrite>>

where

T: AsyncReadWrite,

{

let tls_connector = TlsConnector::from(native_tls::TlsConnector::new()?);

let stream = tls_connector.connect(proxy_domain, stream).await?;

http_connect(stream, target, auth).await

}

#[cfg(not(any(target_os = "windows", target_os = "macos")))]

async fn https_connect<T>(

stream: T,

target: (&str, u16),

auth: Option<HttpProxyAuthorization<'_>>,

proxy_domain: &str,

) -> Result<Box<dyn AsyncReadWrite>>

where

T: AsyncReadWrite,

{

let proxy_domain = rustls_pki_types::ServerName::try_from(proxy_domain)

.context("Address resolution failed")?

.to_owned();

let tls_connector = TlsConnector::from(std::sync::Arc::new(http_client_tls::tls_config()));

let stream = tls_connector.connect(proxy_domain, stream).await?;

http_connect(stream, target, auth).await

}

Thanks! This seems reasonable, but so hard to know...

With my tin foil hat on I am convinced that there's a giant conspiracy by the authors of rust tls libraries to make it impossible to actually set up a project to use tls properly :D

lionel- · 2025-10-22T12:39:11Z

Cargo.toml

 jsonwebtoken = "9.3"
-jupyter-protocol = { git = "https://github.com/ConradIrwin/runtimed", rev = "7130c804216b6914355d15d0b91ea91f6babd734" }
-jupyter-websocket-client = {  git = "https://github.com/ConradIrwin/runtimed" ,rev = "7130c804216b6914355d15d0b91ea91f6babd734" }
+jupyter-protocol = { git = "https://github.com/runtimed/runtimed", rev = "2ba4b96a0d093ae957254b08487696f530ef1b65" }


Conrad's PR (runtimed/runtimed#182) was merged so we should now be able to depend on the main repo.

Does this correspond to an actual released version? Looks like it's tagged with sidecar-v0.8.0, tag: runt-cli-v0.3.0. If so, can we switch back to non-git dependencies?

yep! now updated to latest releases

Ugh, that seems to have broken the tls config

Is there something we need to change in https://github.com/runtimed/runtimed to make this compatible?

rgbkrk · 2025-11-07T00:39:23Z

Cargo.toml

-    "async-dispatcher-runtime",
+runtimelib = { version = "0.29.0", default-features = false, features = [
+    "async-dispatcher-runtime", "ring"
 ] }


Thank you so much for doing this absolutely necessary maintenance work to bring Zed up to the latest.

rgbkrk · 2025-11-13T18:44:37Z

Cargo.toml

-runtimelib = {  git = "https://github.com/ConradIrwin/runtimed", rev = "7130c804216b6914355d15d0b91ea91f6babd734", default-features = false, features = [
-    "async-dispatcher-runtime",
+runtimelib = { version = "0.29.0", default-features = false, features = [
+    "async-dispatcher-runtime", "ring"


Going to push up a change over to aws-lc-rs

ConradIrwin · 2025-11-13T19:23:47Z

@lionel- Ok, we pushed some changes to runtimelib to make sure the feature flags for async-tungstenite match what we use in Zed, to avoid needing to change the tls setup.

Assuming this fixes the build issues, will merge.

rgbkrk · 2025-11-13T21:33:57Z

Thanks @lionel- and @ConradIrwin!

rgbkrk · 2025-11-14T17:08:05Z

Tried it out this morning, it's looking great.

ark-kernel-zed.mp4

…ndustries#40889) Closes zed-industries#40888 This updates runtimed to the latest version, which handles the "starting" variant of `execution_state`. It actually handles a bunch of other variants that are not documented in the protocol (see https://jupyter-client.readthedocs.io/en/stable/messaging.html#kernel-status), like "starting", "terminating", etc. I added implementations for these variants as well. Release Notes: - Fixed issue that prevented the Ark kernel from working in Zed (zed-industries#40888). --------- Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>

cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Oct 22, 2025

lionel- commented Oct 22, 2025

View reviewed changes

SomeoneToIgnore assigned ConradIrwin Oct 22, 2025

rgbkrk reviewed Nov 7, 2025

View reviewed changes

rgbkrk reviewed Nov 13, 2025

View reviewed changes

lionel- and others added 6 commits November 13, 2025 12:10

Update runtimed

98e83a3

Fix error after updating dependencies

5f43927

Reformat

7b52c02

Depend on released versions of runtimed crates

5884003

Revert changes to client

d8d1fcf

Bump to latest version

b27f9ca

ConradIrwin force-pushed the bugfix/kernel-status branch from 0fbc3cb to b27f9ca Compare November 13, 2025 19:22

ConradIrwin enabled auto-merge (squash) November 13, 2025 19:25

ConradIrwin merged commit fa0c750 into zed-industries:main Nov 13, 2025
23 checks passed

lionel- deleted the bugfix/kernel-status branch November 17, 2025 16:23

aymennasri mentioned this pull request Dec 2, 2025

unable to run REPL cells with ark ocsmit/zed-r#35

Closed

	#[cfg(any(target_os = "windows", target_os = "macos"))]
	async fn https_connect<T>(
	stream: T,
	target: (&str, u16),
	auth: Option<HttpProxyAuthorization<'_>>,
	proxy_domain: &str,
	) -> Result<Box<dyn AsyncReadWrite>>
	where
	T: AsyncReadWrite,
	{
	let tls_connector = TlsConnector::from(native_tls::TlsConnector::new()?);
	let stream = tls_connector.connect(proxy_domain, stream).await?;
	http_connect(stream, target, auth).await
	}

	#[cfg(not(any(target_os = "windows", target_os = "macos")))]
	async fn https_connect<T>(
	stream: T,
	target: (&str, u16),
	auth: Option<HttpProxyAuthorization<'_>>,
	proxy_domain: &str,
	) -> Result<Box<dyn AsyncReadWrite>>
	where
	T: AsyncReadWrite,
	{
	let proxy_domain = rustls_pki_types::ServerName::try_from(proxy_domain)
	.context("Address resolution failed")?
	.to_owned();
	let tls_connector = TlsConnector::from(std::sync::Arc::new(http_client_tls::tls_config()));
	let stream = tls_connector.connect(proxy_domain, stream).await?;
	http_connect(stream, target, auth).await
	}

Uh oh!

Conversation

lionel- commented Oct 22, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lionel- Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ConradIrwin commented Nov 13, 2025

Uh oh!

Uh oh!

rgbkrk commented Nov 13, 2025

Uh oh!

rgbkrk commented Nov 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lionel- Oct 28, 2025 •

edited

Loading