project: Always use shell env in LocalLspAdapterDelegate::which#40237
Merged
project: Always use shell env in LocalLspAdapterDelegate::which#40237
LocalLspAdapterDelegate::which#40237Conversation
benbrandt
added a commit
that referenced
this pull request
Jan 15, 2026
Closes: #40237 The env vars were only getting added if a custom command was provided. But it makes sense in either case to be able to specify your env vars, so now these are applied regardless.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows not having a default shell does not matter here, we might still have an environment from other means (by being spawned from the cli for example).
Release Notes: