windows: Fix ascent/descent calculations#40103
Merged
cole-miller merged 1 commit intomainfrom Oct 13, 2025
Merged
Conversation
Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de>
cole-miller
added a commit
that referenced
this pull request
Oct 14, 2025
This reverts commit f1db1f3.
cole-miller
added a commit
that referenced
this pull request
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This applies the same fix as #39886 for Windows.
Previously we were using
GetLineMetricsto determine the ascent and descent values for each line. It seems like this has the same behavior asGetTypographicBoundson macOS, which is to return the minimum ascent and descent for the current state of theTextLayoutobject. This causes the ascent/descent to be unstable when adding or removing an emoji because a font fallback is triggered when an emoji is present on the line.The issue is fixed by switching to
font.GetMetricsto get the ascent and descent, which should always return stable values for the main font, instead of changing when there's a fallback. This also should support situations where we have multiple explicit fonts on the same line, although that probably can't be triggered in Zed right now.Release Notes: