Skip to content

terminal: Add setting for scroll multiplier#39463

Merged
MrSubidubi merged 13 commits intozed-industries:mainfrom
marcocondrache:feat/scroll-multiplier
Nov 12, 2025
Merged

terminal: Add setting for scroll multiplier#39463
MrSubidubi merged 13 commits intozed-industries:mainfrom
marcocondrache:feat/scroll-multiplier

Conversation

@marcocondrache
Copy link
Contributor

Closes #5130

Release Notes:

  • Added setting option for scroll multiplier of the terminal

Signed-off-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com>
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Oct 3, 2025
Signed-off-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com>
@marcocondrache marcocondrache marked this pull request as ready for review October 3, 2025 14:40
Copy link
Member

@MrSubidubi MrSubidubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Left some comments, but other than that, looks good!

Could you please also add some documentation for this within the docs/?

marcocondrache and others added 10 commits October 11, 2025 09:04
Signed-off-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com>
Signed-off-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com>
Signed-off-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com>
Signed-off-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com>
Copy link
Member

@MrSubidubi MrSubidubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for letting this get a bit stale! Briefly raised the issue regarding os-dependent settings internally, and was not too well perceived (understandably), so I decided to just go with what the default is on non-MacOS platforms. Given that I nudged you in the opposite direction at the start, I decided to fix that myself, hope thats fine. Other than that, looks good, so thanks! Will merge after the release cut later today.

@MrSubidubi MrSubidubi merged commit cfbde91 into zed-industries:main Nov 12, 2025
36 of 38 checks passed
@marcocondrache marcocondrache deleted the feat/scroll-multiplier branch November 13, 2025 07:39
11happy pushed a commit to 11happy/zed that referenced this pull request Dec 1, 2025
Closes zed-industries#5130

Release Notes:

- Added setting option for scroll multiplier of the terminal

---------

Signed-off-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com>
Co-authored-by: MrSubidubi <finn@zed.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting to control the terminal scroll sensitivity

2 participants