terminal: Add setting for scroll multiplier#39463
Merged
MrSubidubi merged 13 commits intozed-industries:mainfrom Nov 12, 2025
Merged
terminal: Add setting for scroll multiplier#39463MrSubidubi merged 13 commits intozed-industries:mainfrom
MrSubidubi merged 13 commits intozed-industries:mainfrom
Conversation
Signed-off-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com>
Signed-off-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com>
MrSubidubi
requested changes
Oct 10, 2025
Member
MrSubidubi
left a comment
There was a problem hiding this comment.
Thanks for this! Left some comments, but other than that, looks good!
Could you please also add some documentation for this within the docs/?
Signed-off-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com>
Signed-off-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com>
Signed-off-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com>
Signed-off-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com>
MrSubidubi
approved these changes
Nov 12, 2025
Member
MrSubidubi
left a comment
There was a problem hiding this comment.
Sorry for letting this get a bit stale! Briefly raised the issue regarding os-dependent settings internally, and was not too well perceived (understandably), so I decided to just go with what the default is on non-MacOS platforms. Given that I nudged you in the opposite direction at the start, I decided to fix that myself, hope thats fine. Other than that, looks good, so thanks! Will merge after the release cut later today.
11happy
pushed a commit
to 11happy/zed
that referenced
this pull request
Dec 1, 2025
Closes zed-industries#5130 Release Notes: - Added setting option for scroll multiplier of the terminal --------- Signed-off-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com> Co-authored-by: MrSubidubi <finn@zed.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5130
Release Notes: