Fix select in Helix mode#38117
Merged
kubkon merged 5 commits intozed-industries:mainfrom Sep 14, 2025
Merged
Conversation
Contributor
Author
|
@kubkon, @ConradIrwin I left a mistake and didn't have good test coverage in my previous PR and it has introduced a regression. This should hotfix the problem. |
This was referenced Sep 13, 2025
kubkon
requested changes
Sep 13, 2025
Member
There was a problem hiding this comment.
Nice, you beat me right to it! Selection now works as intended, except when yanking we don't fall back to (helix) normal mode. Would you mind adding that in? I believe we should add that in helix_yank. While we're at it, a test case would be good too to catch any regressions like this in the future.
EDIT: I meant this change:
diff --git a/crates/vim/src/helix.rs b/crates/vim/src/helix.rs
index 369ec2df11..10594e122d 100644
--- a/crates/vim/src/helix.rs
+++ b/crates/vim/src/helix.rs
@@ -345,6 +345,7 @@ impl Vim {
cx,
);
}
+ vim.mode = Mode::HelixNormal;
});
}
kubkon
approved these changes
Sep 14, 2025
Member
kubkon
left a comment
There was a problem hiding this comment.
I'm gonna do ahead and merge this and follow-up with a yank change I mentioned in a subsequent PR. Thanks again for a fix!
kubkon
added a commit
that referenced
this pull request
Sep 14, 2025
Follow-up to #38117. @romaninsh I'd appreciate if you could have a look :-) Release Notes: - N/A
kubkon
added a commit
that referenced
this pull request
Sep 18, 2025
…ly in helix mode (#38119) Closes #34192 Without selection, only current character would be affected. Also if #38117 is merged too, then transformations in SelectMode behave correctly too and selection is not collapsed. Release Notes: - helix: Implemented `~`, `` ` ``, `` Alt-` `` correctly in normal and select modes --------- Co-authored-by: Jakub Konka <kubkon@jakubkonka.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfixes issue I have introduced in #37748.
Without this, helix mode select not working at all in
mainbranch.Release Notes: